feat: Add support for condition role_session_name when assuming a role #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
approved these changes
May 17, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 17, 2023
## [5.19.0](v5.18.0...v5.19.0) (2023-05-17) ### Features * Add support for condition role_session_name when assuming a role ([#379](#379)) ([5aabe67](5aabe67))
|
This PR is included in version 5.19.0 🎉 |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to set as a requirement the parameter role_session_name when a user assumes a role I found that someone created an issue but it has been closed. I need this feature, so I implemented this MR.
I hope this will be useful for the community.
Motivation and Context
The purpose of this condition is to make easier track the user actions when viewing AWS CloudTrail logs, as described in this AWS post
Breaking Changes
Nothing
How Has This Been Tested?
I tested this locally in my environment and it works great. To test this, you need to set your username as role_session_name when assuming the role. If you don´t set your username as this variable, the assumerole will fail.
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request