feat: Added Extra STS actions param in assumable role with SAML #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsyntych
changed the title
|
Hey @bryantbiggs this is a very simple feature that basically mimmics other modules within this project. do you think that it can be merged? thank you! |
antonbabenko
approved these changes
Jan 6, 2023
|
This PR is included in version 5.10.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the abbility to append optional extra trusted roles actions appart from the default "AssumeRoleWithSAML" in the iam-assumable-role-with-saml module
Motivation and Context
Wanted the to utilize the module to avoid rewiting all the logic from scratch but also have the ability to add some extra actions that apply to our use cases.
Breaking Changes
None as far as I know.
How Has This Been Tested?
Internally in our organisation in many deployments. Unable to showcase.