-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting custom trust policy in iam-assumable-role #176
feat: Allow setting custom trust policy in iam-assumable-role #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some improvements
Please check again |
Testing it with all my setups and role combinations all work fine with no changes detected in plan so I hope we are good :) |
Pushed a fix for the failing check, should be all green now. Once you approve, I'll squash fixup commits |
This PR has been automatically marked as stale because it has been open 30 days |
864b81d
to
171a69d
Compare
171a69d
to
5394f8f
Compare
Hi @antonbabenko Is there anything left that needs to be done to merge? |
## [4.10.0](v4.9.0...v4.10.0) (2022-01-19) ### Features * Allow setting custom trust policy in iam-assumable-role ([#176](#176)) ([095cb29](095cb29))
This PR is included in version 4.10.0 🎉 |
Thank you @antonbabenko! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This change adds an option to set a custom trust policy.
Motivation and Context
I need to create an assumable role that can be assumed from all member accounts of the organization except for sandbox accounts.
This can be achieved via conditions and a deny policy for the sandbox.
As there is no possibility to cover all options of the JSON policy, the best would be for such rare situations to allow a custom trust policy.
Breaking Changes
How Has This Been Tested?
examples/*
projects