-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allows multiple STS External IDs to be provided to an assumable role #138
Merged
antonbabenko
merged 11 commits into
terraform-aws-modules:master
from
mike-carey:feature/multiple-sts-external-ids
Mar 11, 2021
Merged
feat: Allows multiple STS External IDs to be provided to an assumable role #138
antonbabenko
merged 11 commits into
terraform-aws-modules:master
from
mike-carey:feature/multiple-sts-external-ids
Mar 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
Mar 3, 2021
antonbabenko
approved these changes
Mar 11, 2021
Thanks, @mike-carey ! v3.13.0 has been just released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows more than one STS External ID to be provided to an assumable role.
Motivation and Context
We need to pass multiple External IDs allowing one role for multiple external ids.
Breaking Changes
No
How Has This Been Tested?
examples/*
projectsI have added the
role_sts_external_ids
field to theiam-assumable-role
example.Using a string
Using a list(string)