feat: Add support for image_configuration block in serverless module #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michalosu
changed the title
bryantbiggs
reviewed
Apr 18, 2023
bryantbiggs
reviewed
Apr 18, 2023
…ation resource - it was added in aws provider 4.62.0
|
@bryantbiggs, could you please review it once again? |
|
@antonbabenko it looks like I don't have permission to run the checks/approve/etc. on this project FYI |
bryantbiggs
reviewed
Apr 22, 2023
modules/serverless/main.tf
Outdated
| for_each = length(var.image_configuration) > 0 ? [var.image_configuration] : [] | ||
|
|
||
| content { | ||
| image_uri = image_configuration.value.image_uri |
There was a problem hiding this comment.
Suggested change
| image_uri = image_configuration.value.image_uri | |
| image_uri = image_configuration.value.image_uri |
|
@bryantbiggs Indeed, some permissions were missing. It was fixed now. All other repositories were already fine. |
bryantbiggs
approved these changes
May 1, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 18, 2023
## [1.1.0](v1.0.0...v1.1.0) (2023-05-18) ### Features * Add support for image_configuration block in serverless module ([#2](#2)) ([4d29ee5](4d29ee5)) ### Bug Fixes * Correct auto-release configuration file ([#6](#6)) ([74847b1](74847b1)) * Update EMR studio service role policy to RequestTags on Create* ([#5](#5)) ([274efc3](274efc3))
|
This PR is included in version 1.1.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for image_configuration block in aws_emrserverless_application resource - it was added in aws provider 4.62.0
Motivation and Context
Added possibility to use custom image in EMR serverless applications
Breaking Changes
It requires aws provider in at least 4.62 version