Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release: now supporting TF 0.12!! #399

Merged
merged 2 commits into from
Jun 19, 2019
Merged

New release: now supporting TF 0.12!! #399

merged 2 commits into from
Jun 19, 2019

Conversation

max-rocket-internet
Copy link
Contributor

@max-rocket-internet max-rocket-internet commented Jun 19, 2019

Feels like we've been waiting forever for this day but now here we are, a big day for any terraform module: support for Terraform version 0.12 🎉🎉🎉

Thanks to the community for getting us here 💙

Also:

  • terraform fmt changes
  • Update README.md variable and output documentation
  • Update pre-commit hooks config, does it look correct @antonbabenko?
  • Update changelog for new 5.0.0 release
  • Fix incorrect compare link for 4.0.2 change log entry

Checklist

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

- id: check-yaml
- id: check-added-large-files
- repo: git://github.com/antonbabenko/pre-commit-terraform
rev: v1.15.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.16.0 is better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK cool

@max-rocket-internet max-rocket-internet merged commit 9c3d222 into terraform-aws-modules:master Jun 19, 2019
@max-rocket-internet max-rocket-internet deleted the new_release_tf_0.12 branch June 19, 2019 15:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants