Upgrade to terraform 0.12 #394

nauxliu · 2019-06-13T14:44:25Z

Description

Add Terraform 0.12 support, resolve #376

This is a fork of alex-goncharov's fork and resolved conflicts

Upgrade Guide

Remove `xx_count` variables from your code

map_accounts_count
map_roles_count
map_users_count
worker_group_count
worker_group_launch_template_mixed_count
worker_group_launch_template_count
workers_additional_policies_count

Replace strings with commas with lists

Affected attributes:

subnets
additional_security_group_ids
suspended_processes
target_group_arns
enabled_metrics
termination_policies

example:

worker_groups = [
  {
    name    = "example"
-   subnets = "subnet-123,subnet-456,subnet-789"
+   subnets = ["subnet-123", "subnet-456", "subnet-789"]
  }
]

Update worker group tags

 worker_groups = [
   {
     name = "example"
+    tags = [
+      {
+        key = "foo"
+        value = "bar"
+        propagate_at_launch = true
+      },
+    ]
   },
 ]

- worker_group_tags = {
-   default = []
-   example = [
-     {
-       key = "foo"
-       value = "bar"
-       propagate_at_launch = true
-     },
-   ]
- }

Update worker_groups_launch_template_mixed override instance types

worker_groups_launch_template_mixed = [
  {
    name                     = "spot-1"
+   override_instance_types  = ["m5.large", "c5.large", "t3.large", "r5.large"]
-   override_instance_type_1 = "m5.large"
-   override_instance_type_2 = "c5.large"
-   override_instance_type_3 = "t3.large"
-   override_instance_type_4 = "r5.large"
    spot_instance_pools      = 3
    asg_max_size             = 5
    asg_desired_size         = 5
    autoscaling_enabled      = true
    kubelet_extra_args       = "--node-labels=kubernetes.io/lifecycle=spot"
  }
]

coalesce(lookup(map, key, ""), default) -> lookup(map, key, default)

* always set a value for these tags * fix tag value * fix tag value * default element available * added default value * added a general default without this default - TF is throwing an error when running a destroy

examples/launch_templates/main.tf

mathuin · 2019-06-13T18:57:59Z

https://github.com/terraform-aws-modules/terraform-aws-vpc/releases/tag/v2.6.0 was released this morning, so you might want to update the example.

mathuin · 2019-06-13T19:08:44Z

Also, possibly an unfair ask, but #338 adds some very useful functionality to v0.11 that would be super helpful in v0.12.

nauxliu · 2019-06-14T04:51:41Z

Also, possibly an unfair ask, but #338 adds some very useful functionality to v0.11 that would be super helpful in v0.12.

@mathuin #338 already merged, there is nothing left to do.

max-rocket-internet · 2019-06-14T10:15:35Z

CHANGELOG.md

@@ -18,6 +18,8 @@ project adheres to [Semantic Versioning](http://semver.org/).

 ### Changed

+- Finally, Terraform 0.12 support (by @alex-goncharov @nauxliu @timboven)
+- All the xx_count variables have been removed (by @nauxliu)


max-rocket-internet · 2019-06-14T10:16:33Z

data.tf

@@ -1,4 +1,5 @@
-data "aws_region" "current" {}
+data "aws_region" "current" {
+}


Does terraform fmt in 0.12 make this change?

terraform 0.12upgrade does

terraform fmt for 0.12.2 appears to be satisfied with either syntax. terraform -0.12upgrade has some unexpected opinions, like ending each file with a double line break, which terraform fmt also appears neutral on.

max-rocket-internet · 2019-06-14T10:18:54Z

Some travis config is broken I think as it says build passed but the log is full of errors

nauxliu · 2019-06-14T10:40:26Z

Some travis config is broken I think as it says build passed but the log is full of errors

@max-rocket-internet Fixed, Ready for review.

max-rocket-internet

Works for me!

max-rocket-internet · 2019-06-14T12:49:36Z

Thanks @nauxliu 🎉

It re-ordered the tags on all my resources but that was all. I'm using one worker_groups_launch_template worker group and one worker_groups_launch_template_mixed.

Let's get some more people to test before merging though.

mcornick · 2019-06-14T16:03:37Z

Tested, works - like @max-rocket-internet I saw some reordering of tags, but nothing destructive. I was previously using the alex-goncharov fork.

mathuin · 2019-06-14T16:40:51Z

Fair warning: I'm a newbie when it comes to terraform.

I'm getting some errors here in some recently-inherited code with this fork:

Error: Unsupported argument

  on main.tf line 143, in module "eks":
 143:   worker_group_launch_template_count   = "1"

An argument named "worker_group_launch_template_count" is not expected here.


Error: Unsupported argument

  on main.tf line 144, in module "eks":
 144:   worker_group_count                   = "0"

An argument named "worker_group_count" is not expected here.

Those two lines are in the module declaration, and appear to be the dreaded xx_count variables which were stripped out. While I accept that they're not desirable, some kind of documentation explaining how to fix code containing them would be desirable. They also still appear in the spot instance docs, so those might need some kind of change as well.

nauxliu · 2019-06-15T01:16:29Z

@mathuin The upgrade guide has been added to the issue description.

nauxliu · 2019-06-15T07:59:55Z

@mathuin @max-rocket-internet @markcornick
I've made two more breaking changes, Could you test again?

sc250024 · 2019-06-15T20:02:20Z

Thanks @nauxliu for taking care of this!

alex-goncharov · 2019-06-17T13:05:41Z

Thans @nauxliu, works for me.

cawilliamson · 2019-06-17T13:28:54Z

@nauxliu This is a little off-topic but is there any simple way I can use this in my existing code right now?

I tried with source = "github.com/nauxliu/terraform-aws-eks.git?ref=feature/0.12" but it looks like TF chokes when you have a branch containing '/'.

endorama · 2019-06-17T13:31:57Z

@cawilliamson this code works for me:

module "ci-cluster" {
  # source  = "terraform-aws-modules/eks/aws"
  # version = "4.0.2"
  source = "git::https://github.com/nauxliu/terraform-aws-eks.git?ref=feature/0.12"
  
  [...]
}

Ensure you commented out the version if any :) First time I tried I just changed source, without removing version and terraform was complaining.

mathuin · 2019-06-17T18:01:00Z

@nauxliu Everything appears to be working!

rbayliss · 2019-06-17T18:30:27Z

This branch worked perfectly for met to spin up a new cluster. I didn't exercise all of the different options, but the basic use case is definitely working.

endorama · 2019-06-18T08:31:32Z

I can confirm it's working here too!

@nauxliu nice work!

krjackso · 2019-06-18T20:10:47Z

Used this branch to upgrade to Terraform 0.12, felt some uneasiness over these lines in the plan:

module.k8s1.module.eks_cluster.local_file.config_map_aws_auth[0] must be replaced
module.k8s1.module.eks_cluster.null_resource.update_config_map_aws_auth[0] must be replaced

But everything worked out okay.

max-rocket-internet · 2019-06-19T07:57:05Z

felt some uneasiness over these lines in the plan:
module.k8s1.module.eks_cluster.local_file.config_map_aws_auth[0] must be replaced
module.k8s1.module.eks_cluster.null_resource.update_config_map_aws_auth[0] must be replaced

I think this is OK. I have these in version control and the contents didn't actually change.

max-rocket-internet · 2019-06-19T07:57:25Z

OK I've done one more test and it looks good to me. I'll merge 🚀

kristofmartens · 2019-06-19T08:51:33Z

Keep in mind this is a breaking change, not a big fan of forcing everybody to terraform 0.12 as not everybody can easily update to this version

github-actions · 2022-11-22T02:29:34Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

alex-goncharov and others added 8 commits May 24, 2019 00:13

run terraform upgrade tool

21c81a3

fix post upgrade TODOs

3aeb17f

use strict typing for variables

2998eeb

upgrade examples, point them at VPC module tf 0.12 PR

07cc34e

remove unnecessary coalesce() calls

0438e43

coalesce(lookup(map, key, ""), default) -> lookup(map, key, default)

Fix autoscaling_enabled broken (#1)

22140b0

always set a value for tags, fix coalescelist calls

2655c4b

* always set a value for these tags * fix tag value * fix tag value * default element available * added default value * added a general default without this default - TF is throwing an error when running a destroy

Merge remote-tracking branch 'origin/master' into feature/0.12

0c5f044

nauxliu changed the title ~~Upgrade to terraform 0.12~~ [WIP] Upgrade to terraform 0.12 Jun 13, 2019

mathuin reviewed Jun 13, 2019

View reviewed changes

examples/launch_templates/main.tf Outdated Show resolved Hide resolved

Fix CI

56d8b3f

max-rocket-internet reviewed Jun 14, 2019

View reviewed changes

nauxliu closed this Jun 14, 2019

nauxliu reopened this Jun 14, 2019

nauxliu changed the title ~~[WIP] Upgrade to terraform 0.12~~ Upgrade to terraform 0.12 Jun 14, 2019

nauxliu added 5 commits June 14, 2019 18:36

Change vpc module back to terraform-aws-modules/vpc/aws in example

89da871

Change type of variable cluster_log_retention_in_days to number

2b26f99

Remove xx_count variables

4258cd6

Actual lists instead of strings with commas

60de281

Update CHANGELOG.md

8ed08f3

max-rocket-internet approved these changes Jun 14, 2019

View reviewed changes

max-rocket-internet mentioned this pull request Jun 14, 2019

add Terraform 0.12 support #376

Closed

4 tasks

nauxliu added 2 commits June 15, 2019 00:47

Remove xx_count variable from docs

694d5ef

Replace element with list indexing

573fe40

nauxliu added 3 commits June 15, 2019 09:50

Change variable worker_group_tags to a attribute of worker_group

8c46750

Fix workers_launch_template_mixed tags

520e475

Change override_instance_type_x variables to list.

c0079c9

Update CHANGELOG.md

2c5b0a8

max-rocket-internet approved these changes Jun 19, 2019

View reviewed changes

max-rocket-internet merged commit da2c78b into terraform-aws-modules:master Jun 19, 2019

helenes-r7 mentioned this pull request Jun 24, 2019

Version 5.0.0 Error: Incorrect attribute value type #401

Closed

4 tasks

nauxliu mentioned this pull request Jun 26, 2019

Arguments not expected there using terraform 0.12 and terraform-aws-eks v5.0.0 #417

Closed

2 tasks

chenrui333 mentioned this pull request Jun 28, 2019

Atlantis latest, tf 0.12.3, tg 0.19.6 chenrui-dev/atlantis-terragrunt#1

Merged

exequielrafaela mentioned this pull request Jul 5, 2019

terraform-aws-eks tf-0.12 support added binbashar/terraform-aws-eks#2

Merged

5 tasks

github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to terraform 0.12 #394

Upgrade to terraform 0.12 #394

nauxliu commented Jun 13, 2019 •

edited

Loading

mathuin commented Jun 13, 2019 •

edited

Loading

mathuin commented Jun 13, 2019

nauxliu commented Jun 14, 2019 •

edited

Loading

max-rocket-internet Jun 14, 2019

max-rocket-internet Jun 14, 2019

nauxliu Jun 14, 2019

eytanhanig Jun 15, 2019

max-rocket-internet commented Jun 14, 2019

nauxliu commented Jun 14, 2019 •

edited

Loading

max-rocket-internet left a comment

max-rocket-internet commented Jun 14, 2019

mcornick commented Jun 14, 2019

mathuin commented Jun 14, 2019

nauxliu commented Jun 15, 2019

nauxliu commented Jun 15, 2019

sc250024 commented Jun 15, 2019

alex-goncharov commented Jun 17, 2019

cawilliamson commented Jun 17, 2019

endorama commented Jun 17, 2019

mathuin commented Jun 17, 2019

rbayliss commented Jun 17, 2019

endorama commented Jun 18, 2019

krjackso commented Jun 18, 2019

max-rocket-internet commented Jun 19, 2019

max-rocket-internet commented Jun 19, 2019

kristofmartens commented Jun 19, 2019

github-actions bot commented Nov 22, 2022

Upgrade to terraform 0.12 #394

Upgrade to terraform 0.12 #394

Conversation

nauxliu commented Jun 13, 2019 • edited Loading

Description

Upgrade Guide

Remove xx_count variables from your code

Replace strings with commas with lists

Update worker group tags

Update worker_groups_launch_template_mixed override instance types

mathuin commented Jun 13, 2019 • edited Loading

mathuin commented Jun 13, 2019

nauxliu commented Jun 14, 2019 • edited Loading

max-rocket-internet Jun 14, 2019

Choose a reason for hiding this comment

max-rocket-internet Jun 14, 2019

Choose a reason for hiding this comment

nauxliu Jun 14, 2019

Choose a reason for hiding this comment

eytanhanig Jun 15, 2019

Choose a reason for hiding this comment

max-rocket-internet commented Jun 14, 2019

nauxliu commented Jun 14, 2019 • edited Loading

max-rocket-internet left a comment

Choose a reason for hiding this comment

max-rocket-internet commented Jun 14, 2019

mcornick commented Jun 14, 2019

mathuin commented Jun 14, 2019

nauxliu commented Jun 15, 2019

nauxliu commented Jun 15, 2019

sc250024 commented Jun 15, 2019

alex-goncharov commented Jun 17, 2019

cawilliamson commented Jun 17, 2019

endorama commented Jun 17, 2019

mathuin commented Jun 17, 2019

rbayliss commented Jun 17, 2019

endorama commented Jun 18, 2019

krjackso commented Jun 18, 2019

max-rocket-internet commented Jun 19, 2019

max-rocket-internet commented Jun 19, 2019

kristofmartens commented Jun 19, 2019

github-actions bot commented Nov 22, 2022

nauxliu commented Jun 13, 2019 •

edited

Loading

Remove `xx_count` variables from your code

mathuin commented Jun 13, 2019 •

edited

Loading

nauxliu commented Jun 14, 2019 •

edited

Loading

nauxliu commented Jun 14, 2019 •

edited

Loading