Add .prettierignore file #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Roth <[email protected]>
Signed-off-by: Andrew Roth <[email protected]>
Signed-off-by: Andrew Roth <[email protected]>
max-rocket-internet
approved these changes
Apr 18, 2019
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
I would like nothing more than to see this PR NOT be merged! Prettier is an amazing plugin (almost 8 million downloads in VS Code extension marketplace alone!)
Without .prettierignore set up, any file I modified got re-formatted by Prettier, which is the desired functionality, but would cause issues if it wasn't expected when submitting PRs.
Checklist
terraform fmtandterraform validateboth work from the root andexamples/eks_test_fixturedirectories (look in CI for an example)