Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster name and ephemeral storage tags for cluster autoscaler #299

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Conversation

tbarrella
Copy link
Contributor

PR o'clock

Description

Adds tags to all node groups to address #297:

  • "k8s.io/cluster-autoscaler/{cluster-name}" (recommended by documentation in case of multiple clusters)
  • "k8s.io/cluster-autoscaler/node-template/resources/ephemeral-storage" to support scaling from 0. Note that the PR to support this in CA is merged into master, but I haven't seen it merged into a release yet

I wasn't sure if it was ok to put these tags in all node groups. Doing so seemed ok since "cluster-autoscaler/disabled" is put in non-CA groups. Could potentially only put these in groups with "autoscaling_enabled," although might need help figuring out how

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features)
  • Test results are pasted in this PR (in lieu of CI)
  • I've added my change to CHANGELOG.md
  • Any breaking changes are highlighted above

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @tbarrella !

@max-rocket-internet max-rocket-internet merged commit efaa3d8 into terraform-aws-modules:master Mar 20, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants