Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annoying typo fix #293

Merged
merged 1 commit into from
Mar 5, 2019
Merged

annoying typo fix #293

merged 1 commit into from
Mar 5, 2019

Conversation

gad0lin
Copy link
Contributor

@gad0lin gad0lin commented Mar 2, 2019 •
edited
Loading

PR o'clock

Description

Changed file name referred in description to match file from repo. Otherwise if you try to find it, you type locals.tf and no file is matched, while the correct file name is local.tf. Simple fix on a bit annoying typo.

Please explain the changes you made here and link to any relevant issues.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features)
  • Test results are pasted in this PR (in lieu of CI)
  • I've added my change to CHANGELOG.md
  • Any breaking changes are highlighted above

@gad0lin gad0lin changed the title typo fix annoying typo fix Mar 2, 2019
max-rocket-internet
max-rocket-internet approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the little things that count! Thanks @gad0lin

@max-rocket-internet max-rocket-internet merged commit dcdf413 into terraform-aws-modules:master Mar 5, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gad0lin @max-rocket-internet