Adding workers_launch_template ebs encryption #292
Conversation
local.tf
Outdated
| @@ -62,6 +62,8 @@ locals { | |||
| root_volume_size = "100" # root volume size of workers instances. | |||
| root_volume_type = "gp2" # root volume type of workers instances, can be 'standard', 'gp2', or 'io1' | |||
| root_iops = "0" # The amount of provisioned IOPS. This must be set with a volume_type of "io1". | |||
| root_encrypted = false # root volume encryption for workers. | |||
| kms_key_id = "" # AWS KMS customer master key to use when creating encrypted volume. ASG must have access to CMK. | |||
There was a problem hiding this comment.
Can you fix the comment here? "customer" is not relevant and what is CMK?
I think just KMS key ID used for encrypted block device would be good 🙂
There was a problem hiding this comment.
@max-rocket-internet updated the comment! Let me know if this looks better. I wanted to make a distinction between the default KMS aws/ebs key and the Customer Master Keys (CMK) that one could want to use
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
Adding EBS encryption option for EKS workers in workers_launch_template
Checklist
terraform fmtandterraform validateboth work from the root andexamples/eks_test_fixturedirectories (look in CI for an example)