Manage aws auth configmap without needing temp files #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
This PR builds on top of #228 and removes the need for temp files altogether by using shell heredocs and file descriptors. This should be handled by most shells, although I've only tested in Bash.
Instead of writing temporary files, we use 2 heredocs to write to file descriptors 3 and 4, with each containing the contents of the config map and the kubectl respectively. We continue with the write_aws_auth_config variable from #228.
Unclear to me is whether this works in zsh, Windows, or pure sh. If it doesn't feel free to reject, but I feel this is MUCH cleaner of an implementation than all this local file management.
Checklist
terraform fmt
andterraform validate
both work from the root andexamples/eks_test_fixture
directories (look in CI for an example)