Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the g3s.xlarge instance type ebs optimized mapping #258

Merged

Conversation

stefansedich
Copy link
Contributor

@stefansedich stefansedich commented Jan 30, 2019

PR o'clock

Description

Just adding the EBS optimized mapping for the g3s.xlarge instance type.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features)
  • Test results are pasted in this PR (in lieu of CI)
  • I've added my change to CHANGELOG.md
  • Any breaking changes are highlighted above

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@max-rocket-internet max-rocket-internet merged commit eac4164 into terraform-aws-modules:master Jan 30, 2019
tekn0ir pushed a commit to tekn0ir/terraform-aws-eks that referenced this pull request Feb 13, 2019
* master:
  Release v2.2.0 (terraform-aws-modules#270)
  Add optional permissions_boundary (terraform-aws-modules#265)
  Updating example IAM docs to include Launch Template actions (terraform-aws-modules#268)
  Added write_aws_auth_config option (terraform-aws-modules#228)
  Worker group tags (terraform-aws-modules#252)
  Adding the g3s.xlarge instance type ebs optimized mapping (terraform-aws-modules#258)
  Add enabled_metrics attributes to autoscaling_group (terraform-aws-modules#256)
  Use launch template defaults for launch template userdata (terraform-aws-modules#255)
  Enable create_before_destroy for ASG and enable force_delete to be configured (terraform-aws-modules#250)
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants