Added write_aws_auth_config option #228

yutachaos · 2018-12-27T05:50:44Z

PR o'clock

Description

Added an option not to create aws_auth configmap.
I made it possible to apply kubectl apply without generating a file to correspond.

Refer issues
#169
#170

Checklist

terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
Tests for the changes have been added and passing (for bug fixes/features)
Test results are pasted in this PR (in lieu of CI)
I've added my change to CHANGELOG.md
Any breaking changes are highlighted above

max-rocket-internet · 2019-01-02T11:11:12Z

aws_auth.tf

+    working_dir = "${path.module}"
+
+    command = <<EOS
+mkfifo aws_auth_configmap kube_config & \


mkfifo won't work on Windows.

Thanks for your comment.
For compatibility with Windows, it changed to a method not using mkfifo command.

max-rocket-internet · 2019-01-02T11:15:35Z

How about simply if a user sets write_kubeconfig=false and manage_aws_auth=true then when TF runs kubectl to apply the aws-auth configmap, it just removes the --kubeconfig option and then it is up to the user solve the authentication themselves?

max-rocket-internet · 2019-01-04T12:00:15Z

I'm still not convinced this is a good approach. Think about these scenarios:

What if the user already has a file called aws_auth_configmap.yaml or kube_config.yaml in CWD? It will be overwritten and then deleted.
What if the user has 2 clusters? TF runs many things in parallel and this could cause either the same config being applied twice or to the wrong cluster.
What the user runs CTRL-C during run? It could leave the files there.

I think you can solve these by writing the file to "${file("${path.module}/..} instead of CWD. Can you test that?

yutachaos · 2019-01-04T12:30:33Z

I am using the local-exec working_dir option to run under module.

FYI
https://www.terraform.io/docs/provisioners/local-exec.html#working_dir

yutachaos · 2019-01-05T00:25:58Z

How about simply if a user sets write_kubeconfig=false and manage_aws_auth=true then when TF runs kubectl to apply the aws-auth configmap, it just removes the --kubeconfig option and then it is up to the user solve the authentication themselves?

I am assuming to use the aws eks update-kubeconfig command.

example

TF runs with write_kubeconfig=false and manage_aws_auth=true options
aws eks update-kubeconfig --name {create-cluster-name}
kubectl get nodes

max-rocket-internet · 2019-01-07T10:05:07Z

I am using the local-exec working_dir option to run under module.

You are right! My mistake, sorry!

I am assuming to use the aws eks update-kubeconfig command.

You mean the AWS CLI? But in this PR, you are not assuming that. If you were assuming that, then we wouldn't need to write kube_config in update_config_map_aws_auth because this would be the responsibility of the user. Right? Or am I misunderstanding?

max-rocket-internet · 2019-01-07T10:05:48Z

Since @philwinder opened the original issue, I've asked them to test this PR 🙂

yutachaos · 2019-01-08T15:14:39Z

You mean the AWS CLI? But in this PR, you are not assuming that. If you were assuming that, then we wouldn't need to write kube_config in update_config_map_aws_auth because this would be the responsibility of the user. Right? Or am I misunderstanding?

Updating using kubeconfig in update_config_map_aws_auth is only used to join eks node to eks cluster.

see
https://docs.aws.amazon.com/eks/latest/userguide/add-user-role.html

yutachaos · 2019-01-29T01:18:21Z

@max-rocket-internet
How about this PR?
If further explanation is necessary, I will add it.
Thank you.

CHANGELOG.md

max-rocket-internet · 2019-01-29T11:04:23Z

Hi @yutachaos
I had a look a couple days ago but there were conflicts. And now this PR is undoing the changes in https://github.com/terraform-aws-modules/terraform-aws-eks/pull/245/files for ZSH compatibility 🙂

Fix that and we can merge.

max-rocket-internet · 2019-01-29T11:04:58Z

aws_auth.tf

+    working_dir = "${path.module}"
+
+    command = <<EOS
+for i in {1..5}; do \


This was changed in #245 for ZSH

Thank you fixed it.

and `write_aws_auth_config` variable for not create the aws_auth files option

max-rocket-internet · 2019-02-01T12:02:14Z

fixes #169
fixes #170

a7i · 2019-02-07T01:17:37Z

@max-rocket-internet Hi there, thank you for adding this. Are there any plans to create a Release Tag?

max-rocket-internet · 2019-02-07T15:54:16Z

Just for you @a7i: https://github.com/terraform-aws-modules/terraform-aws-eks/releases/tag/v2.2.0

* master: Release v2.2.0 (terraform-aws-modules#270) Add optional permissions_boundary (terraform-aws-modules#265) Updating example IAM docs to include Launch Template actions (terraform-aws-modules#268) Added write_aws_auth_config option (terraform-aws-modules#228) Worker group tags (terraform-aws-modules#252) Adding the g3s.xlarge instance type ebs optimized mapping (terraform-aws-modules#258) Add enabled_metrics attributes to autoscaling_group (terraform-aws-modules#256) Use launch template defaults for launch template userdata (terraform-aws-modules#255) Enable create_before_destroy for ASG and enable force_delete to be configured (terraform-aws-modules#250)

github-actions · 2022-11-20T02:32:29Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch from 8878814 to 0779391 Compare December 27, 2018 05:52

max-rocket-internet suggested changes Jan 2, 2019

View reviewed changes

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch from 902f855 to d190055 Compare January 4, 2019 05:34

max-rocket-internet mentioned this pull request Jan 7, 2019

Bug: using write_kubeconfig="false" and manage_aws_auth="true" causes "no such file" #169

Closed

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch from d190055 to a38a290 Compare January 11, 2019 03:36

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch 2 times, most recently from c25c08a to b4005eb Compare January 29, 2019 01:16

max-rocket-internet reviewed Jan 29, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

max-rocket-internet suggested changes Jan 29, 2019

View reviewed changes

mbarrien mentioned this pull request Jan 31, 2019

Manage aws auth configmap without needing temp files #260

Closed

5 tasks

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch from b4005eb to 6c0d103 Compare January 31, 2019 05:20

yutachaos added 5 commits January 31, 2019 14:35

Added update aws auth configmap when manage_aws_auth set false case

a88e21c

and `write_aws_auth_config` variable for not create the aws_auth files option

Add CHANGELOG

fe867ac

Changed writing config file process for Windows compatibility.

e549d42

Apply terraform-docs and terraform fmt

7cd6ea6

Fixed zsh-specific syntax

3f127f9

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch 3 times, most recently from b6b65f9 to 883f1b0 Compare January 31, 2019 05:42

Fixed CHANGELOG.md

64a5785

yutachaos force-pushed the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch from 883f1b0 to 64a5785 Compare January 31, 2019 05:45

max-rocket-internet approved these changes Feb 1, 2019

View reviewed changes

max-rocket-internet merged commit d3c1bd6 into terraform-aws-modules:master Feb 1, 2019

max-rocket-internet mentioned this pull request Feb 1, 2019

Feature request: option to not create the aws_auth files #170

Closed

chenrui333 mentioned this pull request Feb 14, 2019

Disable local_file config in the terraform plan #277

Closed

4 tasks

yutachaos deleted the feature/fixed_aws_auth_configmap_update_when_no_manage_aws_auth branch October 25, 2019 04:39

github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added write_aws_auth_config option #228

Added write_aws_auth_config option #228

yutachaos commented Dec 27, 2018 •

edited

Loading

max-rocket-internet Jan 2, 2019

yutachaos Jan 4, 2019

max-rocket-internet commented Jan 2, 2019

max-rocket-internet commented Jan 4, 2019

yutachaos commented Jan 4, 2019

yutachaos commented Jan 5, 2019 •

edited

Loading

max-rocket-internet commented Jan 7, 2019

max-rocket-internet commented Jan 7, 2019

yutachaos commented Jan 8, 2019

yutachaos commented Jan 29, 2019

max-rocket-internet commented Jan 29, 2019

max-rocket-internet Jan 29, 2019

yutachaos Jan 31, 2019

max-rocket-internet commented Feb 1, 2019

a7i commented Feb 7, 2019

max-rocket-internet commented Feb 7, 2019

github-actions bot commented Nov 20, 2022

Added write_aws_auth_config option #228

Added write_aws_auth_config option #228

Conversation

yutachaos commented Dec 27, 2018 • edited Loading

PR o'clock

Description

Checklist

max-rocket-internet Jan 2, 2019

Choose a reason for hiding this comment

yutachaos Jan 4, 2019

Choose a reason for hiding this comment

max-rocket-internet commented Jan 2, 2019

max-rocket-internet commented Jan 4, 2019

yutachaos commented Jan 4, 2019

yutachaos commented Jan 5, 2019 • edited Loading

max-rocket-internet commented Jan 7, 2019

max-rocket-internet commented Jan 7, 2019

yutachaos commented Jan 8, 2019

yutachaos commented Jan 29, 2019

max-rocket-internet commented Jan 29, 2019

max-rocket-internet Jan 29, 2019

Choose a reason for hiding this comment

yutachaos Jan 31, 2019

Choose a reason for hiding this comment

max-rocket-internet commented Feb 1, 2019

a7i commented Feb 7, 2019

max-rocket-internet commented Feb 7, 2019

github-actions bot commented Nov 20, 2022

yutachaos commented Dec 27, 2018 •

edited

Loading

yutachaos commented Jan 5, 2019 •

edited

Loading