Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker_group_tags doesn't work #451

Closed
2 of 3 tasks
eug-maly opened this issue Jul 30, 2019 · 4 comments
Closed
2 of 3 tasks

worker_group_tags doesn't work #451

eug-maly opened this issue Jul 30, 2019 · 4 comments

Comments

@eug-maly
Copy link

eug-maly commented Jul 30, 2019

I have issues

Cannot add tags per worker_group

I'm submitting a...

  • bug report
  • support request
  • kudos, thank you, warm fuzzy

What is the current behavior?

I want to have 2 worker groups, each with custom tag. For example, if I use this template - https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v4.0.2/examples/basic/main.tf

I've added to variables.tf:
`
variable "worker_group_tags" {
description = "A map defining extra tags to be applied to the worker group ASG."
type = "map"

default = {
worker-group-1 = [
{ selector = "wg1" },
{ tag2 = "value2" }
]
worker-group-2 = [
{ selector = "wg2" },
{ tag2 = "value2" }
]
}
}
`

However, no tags were added.

If this is a bug, how to reproduce? Please include a code sample if relevant.

What's the expected behavior?

Tags are added as specified

Are you able to fix this problem and submit a PR? Link here if you have already.

Environment details

  • Affected module version:v4.0.2
  • OS:
  • Terraform v0.11.14
  • provider.aws v2.20.0
  • provider.helm v0.10.0
  • provider.kubernetes v1.8.1
  • provider.local v1.3.0
  • provider.null v2.1.2
  • provider.template v2.1.2

Any other relevant info

@eug-maly
Copy link
Author

eug-maly commented Aug 1, 2019

Found that it was implemented in #252
and example was added (but now it is missed in examples):
062c229

@eug-maly eug-maly closed this as completed Aug 1, 2019
@max-rocket-internet
Copy link
Contributor

Maybe we need a better example of this?

@eug-maly
Copy link
Author

eug-maly commented Aug 1, 2019

I didn't find the help on stackoverflow and telegram chats in a short time. so, better example could save someone's time

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants