Replace the enable-docker-bridge parameter with a generic one

[RothAndrew]

I have issues

per @max-rocket-internet's comment here in #310 :

Maybe we just replace the enable-docker-bridge parameter with just a general parameter like bootstrap_extra_args that defaults to "". This is safer for AMI changes, will solve this issue and means people can change the docker bridge setting also.

Note: This would be a breaking change which would mean a major version bump.

I'm submitting a...

• bug report
• feature request
• support request
• kudos, thank you, warm fuzzy

What is the current behavior?

Older AMI's don't work since they don't have the new --enable-docker-bridge flag, but this module adds it with a true or false. Changing it to a generic parameter like bootstrap_extra_args will eliminate that issue and add future proofing for other similar stuff that may come up in the future.

Are you able to fix this problem and submit a PR? Link here if you have already.

I am capable of doing a PR. I don't have the time right now, but if this sits untouched for long enough I will eventually come along to do it.

Fixes #310

[max-rocket-internet]

Maybe @michaelmccord can make the PR 😃

[michaelmccord]

@max-rocket-internet -- I'll try and make some time to get around to this.

[max-rocket-internet]

I made a PR: #320

@RothAndrew could you test it perhaps??

[RothAndrew]

I will give it a shot :)

[RothAndrew]

Testing this now, about 20 days late, sorry :)

[max-rocket-internet]

This was resolved with the PR above.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.