Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix provider version for staging and continuous_deployment_policy_id params #132

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

zahorniak
Copy link
Contributor

AWS Terraform provider version lower than 5.12.0 doesn't support staging and continuous_deployment_policy_id params which were added in the new version v3.3.0 of this module.

Description

Set and new min version of Terraform provider

Motivation and Context

It fixes failing plan/applies when AWS Terraform provider version lower than 5.12.0

Breaking Changes

Yes, this looks like breaking change and requires a new major version of module. However, it's already broken...

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko merged commit 334f2f7 into terraform-aws-modules:master Mar 4, 2024
7 checks passed
@antonbabenko
Copy link
Member

Thank you for the fix!

antonbabenko pushed a commit that referenced this pull request Mar 4, 2024
### [3.3.1](v3.3.0...v3.3.1) (2024-03-04)

### Bug Fixes

* Fix provider version for `staging` and `continuous_deployment_policy_id` params ([#132](#132)) ([334f2f7](334f2f7))
@antonbabenko
Copy link
Member

This PR is included in version 3.3.1 🎉

Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants