Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fix handling of sequence_length w/ beam search decoder" #494

Closed
guillaumekln opened this issue Sep 10, 2019 · 3 comments
Closed
Labels
bug Something isn't working seq2seq

Comments

@guillaumekln
Copy link
Contributor

System information

  • OS Platform and Distribution: Ubuntu 16.04
  • TensorFlow version and how it was installed: binary
  • TensorFlow-Addons version and how it was installed: binary
  • Python version: 3.6
  • Is GPU used? No

Describe the bug

For some reasons, patches are still pushed to tf.contrib.seq2seq, see:

tensorflow/tensorflow@8bbc039

The bug is described in the commit message.

Code to reproduce the issue

None.

Other info / logs

@qlzh727 as you refactored the seq2seq module, do you confirm this bug is also applicable to the addons version?

@guillaumekln guillaumekln added bug Something isn't working seq2seq labels Sep 10, 2019
@qlzh727
Copy link
Member

qlzh727 commented Sep 10, 2019

Thanks for the notice, let me take a look for the change in contrib.

As a side note, since addons hasn't been port into google internal yet, eng within google is still using existing contrib version of seq2seq.

@qlzh727
Copy link
Member

qlzh727 commented Sep 10, 2019

I think tensorflow/tensorflow@8bbc039 should be mirrored to addons. let me send a PR quickly

@ebrevdo
Copy link

ebrevdo commented Sep 27, 2019

@qlzh727 thanks so much for handling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working seq2seq
Projects
None yet
Development

No branches or pull requests

3 participants