From 2ca23ec36b1bfc297c5521c79e65124289cc965d Mon Sep 17 00:00:00 2001 From: Michael Snowden Date: Mon, 7 Nov 2022 10:22:54 -0800 Subject: [PATCH] Add metrics scopes for the archival queue --- common/metrics/metric_defs.go | 8 ++++++++ common/persistence/persistenceMetricClients.go | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/common/metrics/metric_defs.go b/common/metrics/metric_defs.go index dbae56d9e55..0fb9144ea27 100644 --- a/common/metrics/metric_defs.go +++ b/common/metrics/metric_defs.go @@ -694,6 +694,14 @@ const ( PersistenceRangeCompleteVisibilityTasksScope = "RangeCompleteVisibilityTasks" // PersistenceGetReplicationTaskScope tracks GetReplicationTask calls made by service to persistence layer PersistenceGetReplicationTaskScope = "GetReplicationTask" + // PersistenceGetArchivalTaskScope tracks GetArchivalTask calls made by service to persistence layer + PersistenceGetArchivalTaskScope = "GetArchivalTask" + // PersistenceGetArchivalTasksScope tracks GetArchivalTasks calls made by service to persistence layer + PersistenceGetArchivalTasksScope = "GetArchivalTasks" + // PersistenceCompleteArchivalTaskScope tracks CompleteArchivalTasks calls made by service to persistence layer + PersistenceCompleteArchivalTaskScope = "CompleteArchivalTask" + // PersistenceRangeCompleteArchivalTasksScope tracks CompleteArchivalTasks calls made by service to persistence layer + PersistenceRangeCompleteArchivalTasksScope = "RangeCompleteArchivalTasks" // PersistenceGetReplicationTasksScope tracks GetReplicationTasks calls made by service to persistence layer PersistenceGetReplicationTasksScope = "GetReplicationTasks" // PersistenceCompleteReplicationTaskScope tracks CompleteReplicationTasks calls made by service to persistence layer diff --git a/common/persistence/persistenceMetricClients.go b/common/persistence/persistenceMetricClients.go index 3317ef539d5..8da3b1eb3eb 100644 --- a/common/persistence/persistenceMetricClients.go +++ b/common/persistence/persistenceMetricClients.go @@ -331,6 +331,8 @@ func (p *executionPersistenceClient) GetHistoryTask( operation = metrics.PersistenceGetVisibilityTaskScope case tasks.CategoryIDReplication: operation = metrics.PersistenceGetReplicationTaskScope + case tasks.CategoryIDArchival: + operation = metrics.PersistenceGetArchivalTaskScope default: return nil, serviceerror.NewInternal(fmt.Sprintf("unknown task category type: %v", request.TaskCategory)) } @@ -357,6 +359,8 @@ func (p *executionPersistenceClient) GetHistoryTasks( operation = metrics.PersistenceGetVisibilityTasksScope case tasks.CategoryIDReplication: operation = metrics.PersistenceGetReplicationTasksScope + case tasks.CategoryIDArchival: + operation = metrics.PersistenceGetArchivalTasksScope default: return nil, serviceerror.NewInternal(fmt.Sprintf("unknown task category type: %v", request.TaskCategory)) } @@ -383,6 +387,8 @@ func (p *executionPersistenceClient) CompleteHistoryTask( operation = metrics.PersistenceCompleteVisibilityTaskScope case tasks.CategoryIDReplication: operation = metrics.PersistenceCompleteReplicationTaskScope + case tasks.CategoryIDArchival: + operation = metrics.PersistenceCompleteArchivalTaskScope default: return serviceerror.NewInternal(fmt.Sprintf("unknown task category type: %v", request.TaskCategory)) } @@ -409,6 +415,8 @@ func (p *executionPersistenceClient) RangeCompleteHistoryTasks( operation = metrics.PersistenceRangeCompleteVisibilityTasksScope case tasks.CategoryIDReplication: operation = metrics.PersistenceRangeCompleteReplicationTasksScope + case tasks.CategoryIDArchival: + operation = metrics.PersistenceRangeCompleteArchivalTasksScope default: return serviceerror.NewInternal(fmt.Sprintf("unknown task category type: %v", request.TaskCategory)) }