Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap workflow task timeout on continue as new #3811

Closed
yycptt opened this issue Jan 18, 2023 · 0 comments
Closed

Cap workflow task timeout on continue as new #3811

yycptt opened this issue Jan 18, 2023 · 0 comments
Assignees
@yycptt
Labels
bug Something isn't working difficulty: easy

Comments

@yycptt
Copy link
Member

yycptt commented Jan 18, 2023

Expected Behavior

Workflow task timeout is always capped.

Actual Behavior

User can set arbitrary long workflow task timeout via workflow.WithWorkflowTaskTimeout() and do a continue as new. And in the new run, the workflow task timeout is not capped, and whatever value specified by our user will be used.

Steps to Reproduce the Problem

Specifications

  • Version:
  • Platform:
@yycptt yycptt added bug Something isn't working difficulty: easy labels Jan 18, 2023
@yiminc yiminc assigned pdoerner and yycptt and unassigned pdoerner Jan 20, 2023
@yycptt yycptt mentioned this issue Jan 25, 2023
Merged
@yycptt yycptt closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yycptt yycptt

Labels
bug Something isn't working difficulty: easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yycptt @pdoerner