Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history_size_bytes to WorkflowExecutionInfo and PollWorkflowTaskQueueResponse #1114

Closed
mfateev opened this issue Dec 18, 2020 · 1 comment
Closed

Add history_size_bytes to WorkflowExecutionInfo and PollWorkflowTaskQueueResponse #1114

mfateev opened this issue Dec 18, 2020 · 1 comment
Assignees
@dnr
Labels
API Issues/features involving the API difficulty: easy enhancement New feature or request good first issue Good for newcomers

Comments

@mfateev
Copy link
Member

mfateev commented Dec 18, 2020

Is your feature request related to a problem? Please describe.
Controlling a workflow history size is important to keep the system performant. None of the existing APIs exposes the aggregated size of the history.

Describe the solution you'd like
Add history_size_bytes to WorkflowExecutionInfo (returned from DescribeWorkflowExecution) and PollWorkflowTaskQueueResponse.
@mfateev mfateev added the enhancement New feature or request label Dec 18, 2020
@samarabbas samarabbas added good first issue Good for newcomers difficulty: easy API Issues/features involving the API labels Jul 4, 2021
@yiminc
Copy link
Member

yiminc commented Apr 27, 2022

Should also expose history size to workflow task started event so workflow code can access this info as well as they might use it to decide if continue as new is needed.

@dnr dnr mentioned this issue Apr 29, 2022
Merged
@dnr dnr mentioned this issue Jul 5, 2022
Merged
@cretz cretz mentioned this issue Oct 27, 2022
Open
@sync-by-unito sync-by-unito bot closed this as completed Mar 3, 2023
@yiminc yiminc reopened this Mar 3, 2023
@yiminc yiminc closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnr dnr

Labels
API Issues/features involving the API difficulty: easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dnr @mfateev @samarabbas @yiminc