diff --git a/common/metrics/metric_defs.go b/common/metrics/metric_defs.go index 9678dace09f..d538af7efee 100644 --- a/common/metrics/metric_defs.go +++ b/common/metrics/metric_defs.go @@ -1594,6 +1594,7 @@ var ( ElasticsearchBulkProcessorBulkSize = NewDimensionlessHistogramDef("elasticsearch_bulk_processor_bulk_size") ElasticsearchDocumentParseFailuresCount = NewCounterDef("elasticsearch_document_parse_failures_counter") ElasticsearchDocumentGenerateFailuresCount = NewCounterDef("elasticsearch_document_generate_failures_counter") + ElasticsearchCustomOrderByClauseCount = NewCounterDef("elasticsearch_custom_order_by_clause_counter") CatchUpReadyShardCountGauge = NewGaugeDef("catchup_ready_shard_count") HandoverReadyShardCountGauge = NewGaugeDef("handover_ready_shard_count") ReplicatorMessages = NewCounterDef("replicator_messages") diff --git a/common/persistence/visibility/store/elasticsearch/visibility_store.go b/common/persistence/visibility/store/elasticsearch/visibility_store.go index de67efd3f16..dab68fec65d 100644 --- a/common/persistence/visibility/store/elasticsearch/visibility_store.go +++ b/common/persistence/visibility/store/elasticsearch/visibility_store.go @@ -735,6 +735,7 @@ func (s *visibilityStore) setDefaultFieldSort(fieldSorts []*elastic.FieldSort) [ return defaultSorter } + s.metricsHandler.Counter(metrics.ElasticsearchCustomOrderByClauseCount.GetMetricName()).Record(1) res := make([]elastic.Sorter, len(fieldSorts)+1) for i, fs := range fieldSorts { res[i] = fs diff --git a/common/persistence/visibility/store/elasticsearch/visibility_store_read_test.go b/common/persistence/visibility/store/elasticsearch/visibility_store_read_test.go index 9a972a2cec9..1a302ee5735 100644 --- a/common/persistence/visibility/store/elasticsearch/visibility_store_read_test.go +++ b/common/persistence/visibility/store/elasticsearch/visibility_store_read_test.go @@ -460,6 +460,7 @@ func (s *ESVisibilitySuite) TestBuildSearchParametersV2() { // test custom sort request.Query = `Order bY WorkflowId` boolQuery = elastic.NewBoolQuery().Filter(matchNamespaceQuery).MustNot(namespaceDivisionExists) + s.mockMetricsHandler.EXPECT().Counter(metrics.ElasticsearchCustomOrderByClauseCount.GetMetricName()).Return(metrics.NoopCounterMetricFunc) p, err = s.visibilityStore.buildSearchParametersV2(request) s.NoError(err) s.Equal(&client.SearchParameters{