Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] FailureConverters should not be reported as PayloadConverters in error messages #1369

Closed
antlai-temporal opened this issue Feb 27, 2024 · 1 comment
Closed

[Bug] FailureConverters should not be reported as PayloadConverters in error messages #1369

antlai-temporal opened this issue Feb 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@antlai-temporal
Copy link
Contributor

Describe the bug

The errors thrown by data converters should be made more generic by using ${type} instead of hardcoding payloadConverter, and also
these error messages should use methods that are failure converter specific when needed.
@antlai-temporal antlai-temporal added the bug Something isn't working label Feb 27, 2024
@antlai-temporal antlai-temporal mentioned this issue Mar 8, 2024
Merged
@mjameswh
Copy link
Contributor

Resolved by #1373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjameswh @antlai-temporal