Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add memo update feature #557

Closed
KorDum opened this issue Jan 28, 2025 · 4 comments · Fixed by temporalio/roadrunner-temporal#617 or #562
Closed

[Feature Request] Add memo update feature #557

KorDum opened this issue Jan 28, 2025 · 4 comments · Fixed by temporalio/roadrunner-temporal#617 or #562
Milestone

Comments

@KorDum
Copy link

KorDum commented Jan 28, 2025

Is your feature request related to a problem? Please describe.

From the documentation, it seems that workflow has the ability to specify memo notes (additional metadata) that could be used later in searches. I see in the PHP SDK the ability to populate a memo when workflow starts, but I don't see the ability to populate a memo during workflow execution.

I have an order creation workflow where I have the order number appear. I would like to add it to the memo and then use it when investigating incidents.

Maybe there's some other way?

Describe the solution you'd like

I'd like something like this:

Workflow::addMemo('key', 'value');

Additional context

Memo documentation

@KorDum KorDum changed the title [Feature Request] FILL_TITLE_HERE [Feature Request] Add memo update feature Jan 28, 2025
@roxblnfk
Copy link
Collaborator

roxblnfk commented Jan 28, 2025

Maybe there's some other way?

Hi. It looks like Search Attributes can be more useful in this case.
We are going to expose Typed Search Attributes with the next minor release.

But now you can use untyped ones https://php.temporal.io/classes/Temporal-Workflow.html#method_upsertSearchAttributes

@KorDum
Copy link
Author

KorDum commented Jan 29, 2025

Thanks for the reply!
Will these attributes also be searchable through the Temporal UI?

@roxblnfk
Copy link
Collaborator

roxblnfk commented Jan 29, 2025

Yes. They will be visible, indexed, and searchable like WorkflowId or WorkflowType
https://docs.temporal.io/visibility#search-attribute

@KorDum KorDum closed this as completed Jan 29, 2025
@rustatian rustatian reopened this Jan 29, 2025
@rustatian
Copy link
Collaborator

@roxblnfk
Command name: UpsertMemo.
Json payload name: memo. Type map[string]any like in Search (not typed) attributes.

type UpsertMemo struct {
	// Memos to update.
	Memo map[string]any `json:"memo"`
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants