Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support new failure field in query responses #867

Open
Sushisource opened this issue Jan 23, 2025 · 3 comments
Open

[Feature Request] Support new failure field in query responses #867

Sushisource opened this issue Jan 23, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@Sushisource
Copy link
Member

Is your feature request related to a problem? Please describe.

The query response proto(s) now support sending a Failure rather than just an error message. Support this. Code contains TODOs with this issue number.

@Sushisource Sushisource added the enhancement New feature or request label Jan 23, 2025
@sainad2222
Copy link

Can you give more information about this feature request? I'd like to work on it
What proto message is this?

@Sushisource
Copy link
Member Author

@sainad2222 Thanks for your interest. The issue mentions you can search for this number, that leads you to two places the client needs to be changed and that's mostly it. This function will need to be changed to return the whole failure instead of just the string message. The error message field will need to continue to be set to support older servers.

Some tests will need to be added as well to verify the complete failure makes it to the server.

@sainad2222
Copy link

If I understood correctly wherever we are sending just message as String in that function, now we also needs to send Failure proto like this(just message field)?

Failure{
    message: err.message
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants