Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TEMPORAL_ENV may not be working #541

Closed
cretz opened this issue Apr 29, 2024 · 1 comment
Closed

[Bug] TEMPORAL_ENV may not be working #541

cretz opened this issue Apr 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Apr 29, 2024

Describe the bug

Confirm TEMPORAL_ENV env var properly sets the equivalent of --env. This may require special handling since that flag is used before others (because it governs what the other flags have to be).

@cretz cretz added the bug Something isn't working label Apr 29, 2024
@josh-berry
Copy link
Collaborator

Took a quick look at the code and preprocessOptions() does not appear to check the environment variable, but looks directly at the command line arguments. So I think this is an implementation oversight.

(We should probably have more testing around --env in general I think; I noticed another regression around temporal env delete I'll have to either fix or write up properly tomorrow.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants