Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Ensure remote codec used for all payloads in and out #367

Open
cretz opened this issue Oct 19, 2023 · 3 comments
Open

[Bug] Ensure remote codec used for all payloads in and out #367

cretz opened this issue Oct 19, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Oct 19, 2023

Describe the bug

When setting --codec-endpoint it appears to set a custom data converter globally for a few uses, but we need to make sure it's used for all input and ouput payloads (that are not search attributes)
@cretz cretz added the bug Something isn't working label Oct 19, 2023
@bergundy
Copy link
Member

Also related: #22

@lorensr
Copy link
Contributor

lorensr commented Oct 24, 2023

User reports JSON not getting decoded in:

temporal workflow show --codec-endpoint=[endpoint] --output=json

@dandavison dandavison mentioned this issue Nov 13, 2023
Closed
1 task
@sync-by-unito sync-by-unito bot closed this as completed Jan 16, 2024
@dandavison dandavison reopened this Jan 19, 2024
@cretz
Copy link
Member Author

cretz commented Jan 20, 2024

(will also be implicitly solved by #415 and CLI rework btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use gRPC interceptor instead of data converter for encoding/decoding dandavison/temporalio-cli
4 participants
@dandavison @bergundy @cretz @lorensr