From 3329c9a2c3ba3e827bf97f7363db24839511a825 Mon Sep 17 00:00:00 2001 From: Yichao Yang Date: Sat, 11 Mar 2023 14:28:51 -0800 Subject: [PATCH 1/2] Add failed cause for signal count limit --- temporal/api/enums/v1/failed_cause.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/temporal/api/enums/v1/failed_cause.proto b/temporal/api/enums/v1/failed_cause.proto index eff1fcd2..368d5d16 100644 --- a/temporal/api/enums/v1/failed_cause.proto +++ b/temporal/api/enums/v1/failed_cause.proto @@ -108,6 +108,7 @@ enum SignalExternalWorkflowExecutionFailedCause { SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_UNSPECIFIED = 0; SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_EXTERNAL_WORKFLOW_EXECUTION_NOT_FOUND = 1; SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_NAMESPACE_NOT_FOUND = 2; + SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_SIGNAL_COUNT_LIMIT_EXCEEDED = 3; } enum ResourceExhaustedCause { From bff502215944023353a7f3c5e8643132cd2368fc Mon Sep 17 00:00:00 2001 From: Yichao Yang Date: Mon, 20 Mar 2023 11:05:00 -0700 Subject: [PATCH 2/2] add comments --- temporal/api/enums/v1/failed_cause.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/temporal/api/enums/v1/failed_cause.proto b/temporal/api/enums/v1/failed_cause.proto index 368d5d16..d2299137 100644 --- a/temporal/api/enums/v1/failed_cause.proto +++ b/temporal/api/enums/v1/failed_cause.proto @@ -108,6 +108,7 @@ enum SignalExternalWorkflowExecutionFailedCause { SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_UNSPECIFIED = 0; SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_EXTERNAL_WORKFLOW_EXECUTION_NOT_FOUND = 1; SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_NAMESPACE_NOT_FOUND = 2; + // Signal count limit is per workflow and controlled by server dynamic config "history.maximumSignalsPerExecution" SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_SIGNAL_COUNT_LIMIT_EXCEEDED = 3; }