Skip to content

Commit

Permalink
revert(link): remove unnecessary attribute
Browse files Browse the repository at this point in the history
role in Button Link and title in Chevron link
  • Loading branch information
lzcabrera committed Aug 22, 2017
1 parent 389a4a8 commit 469fd2b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions src/components/Link/ButtonLink/ButtonLink.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ const ButtonLink = ({ reactRouterLinkComponent, variant, invert, children, ...re
reactRouterLinkComponent || 'a',
{
...safeRest(rest),
className: getClassName(variant, invert),
role: 'button'
className: getClassName(variant, invert)
},
children
)
Expand Down
3 changes: 1 addition & 2 deletions src/components/Link/ChevronLink/ChevronLink.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ const ChevronLink = ({ reactRouterLinkComponent, variant, direction, children, .
reactRouterLinkComponent || 'a',
{
...safeRest(rest),
className: getClassName(variant),
title: children
className: getClassName(variant)
},
direction === 'left' ? getIcon('left-chevron', styles.leftChevron) : undefined,
children,
Expand Down

0 comments on commit 469fd2b

Please sign in to comment.