From eac928dbc9c9bf5332b067085bb8aa4d5a978698 Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Mon, 27 May 2024 11:46:05 +0200 Subject: [PATCH 1/3] release nodemailer transport resources --- lib/models/emailAction.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/models/emailAction.js b/lib/models/emailAction.js index 4e42cb8e..50721584 100644 --- a/lib/models/emailAction.js +++ b/lib/models/emailAction.js @@ -64,13 +64,13 @@ function buildMailOptions(action, event) { } function SendMail(action, event, callback) { + var transporter; try { // setup e-mail data with unicode symbols var mailOptions = buildMailOptions(action, event), transporterOptions = buildTransporterOptions(action, event), opt2log, smtpConfig, - transporter, msgFromConfig; if (transporterOptions.smtp) { @@ -119,6 +119,11 @@ function SendMail(action, event, callback) { // Not an HTTP request, so outgoingTransacion hasn't already counted and must be counted now metrics.IncMetrics(event.service, event.subservice, metrics.outgoingTransactionsErrors); return callback(ex); + } finally { + if (transporter) { + // release resources + transporter.close(); + } } } From 5dc54c6b88a14e6bbdf652b6c7e15b01e9e46a1f Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Thu, 30 May 2024 17:20:54 +0200 Subject: [PATCH 2/3] Update CHANGES_NEXT_RELEASE --- CHANGES_NEXT_RELEASE | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE index 14c43876..b1856fc5 100644 --- a/CHANGES_NEXT_RELEASE +++ b/CHANGES_NEXT_RELEASE @@ -1,2 +1,3 @@ +- Release transport resources of nodemailer after send email - Upgrade express dep from 4.18.1 to 4.19.2 due to a vulnerability - Upgrade nodemailer dep from 6.6.5 to 6.9.13 due to a vulnerability From 0aaacb47f066f9cc411a810bf2b5c8d22b3cacca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ferm=C3=ADn=20Gal=C3=A1n=20M=C3=A1rquez?= Date: Fri, 31 May 2024 09:55:17 +0200 Subject: [PATCH 3/3] Update CHANGES_NEXT_RELEASE --- CHANGES_NEXT_RELEASE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE index b1856fc5..60026c36 100644 --- a/CHANGES_NEXT_RELEASE +++ b/CHANGES_NEXT_RELEASE @@ -1,3 +1,3 @@ -- Release transport resources of nodemailer after send email +- Fix: release transport resources of nodemailer after send email - Upgrade express dep from 4.18.1 to 4.19.2 due to a vulnerability - Upgrade nodemailer dep from 6.6.5 to 6.9.13 due to a vulnerability