Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

It's only possible to extract conclusions for 30 jobs #27

Closed
JessikaNilsson opened this issue Jun 18, 2020 · 1 comment · Fixed by #28
Closed

It's only possible to extract conclusions for 30 jobs #27

JessikaNilsson opened this issue Jun 18, 2020 · 1 comment · Fixed by #28
Assignees
Labels
Type: Bug Something isn't working

Comments

@JessikaNilsson
Copy link

JessikaNilsson commented Jun 18, 2020

Describe the bug:

There is no information regarding a limit to how many jobs can be analysed for conclusions, and as no limit is defined I suppose there's not supposed to be one?

We have 34 jobs that should be analysed, but information is only fetched for the 30 first ones and not the last ones...

We see this count : { total_count: 34, jobs: [ [Object], [Object], [Object], [Object] ] }

But the 'jobs' array only containts 30, and we get Conclusions: [ 'success', 'undefined' ], and Conclusion: success, even though we know that job nbr 33 failed...

To Reproduce:

Steps to reproduce the behavior:

  1. Have a workflow with more than 30 jobs/actions (yml file)
  2. Job number 31 should be a failing one (returning non-zero value)
  3. Job number 32 should contain a check for conclusion of the previous jobs using your code
    slackNotification:
Z:
name: Z
    needs: [X, Y]
    runs-on: ubuntu-latest
    if: always()
    steps:
      - uses: technote-space/workflow-conclusion-action@v1
  1. Run the tests and check the results of jobs, conclusions and conclusion, if bug is reproduced the conclusion will be success and the 31st job won't be in the list of jobs.

Expected behavior:

When the check for jobs and their conclusion is done, they should check all the available jobs and not only the first 30 jobs. Also, if 'undefined' is in the conclusions array, the resulting conclusion shouldn't be 'success'

Screenshots:

Screenshot 2020-06-18 at 16 04 38

Operating environment:

  • Version of software
  • OS: Ubuntu
  • Browser: -
  • etc.

Additional context:

We use your code to retrieve the conclusion of all the jobs, to verify whether a Slack notification should be sent or not. Since the last jobs are not checked by your code, no notification is sent despite jobs failing...

@welcome
Copy link

welcome bot commented Jun 18, 2020

🙌 Thanks for opening your first issue here! Be sure to follow the issue template!

@triage-new-issues triage-new-issues bot added the triage Labeling is needed label Jun 18, 2020
@technote-space technote-space added the Type: Bug Something isn't working label Jun 20, 2020
@triage-new-issues triage-new-issues bot removed the triage Labeling is needed label Jun 20, 2020
@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Jun 24, 2020
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants