From 54182d8340bb7ebfbafac8989975b5c38a1e60d0 Mon Sep 17 00:00:00 2001 From: Sua Yoo Date: Fri, 15 Jan 2021 10:23:42 -0800 Subject: [PATCH 1/3] update for interface --- packages/react-client/example/src/VideoCall.tsx | 2 -- packages/react-client/src/useTelnyxRTC.ts | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/react-client/example/src/VideoCall.tsx b/packages/react-client/example/src/VideoCall.tsx index 07fd0bd5..677ed327 100644 --- a/packages/react-client/example/src/VideoCall.tsx +++ b/packages/react-client/example/src/VideoCall.tsx @@ -45,8 +45,6 @@ function VideoCall() { destinationNumber: destination, callerName: process.env.REACT_APP_TELNYX_PHONE_NUMBER || '', callerNumber: process.env.REACT_APP_TELNYX_PHONE_NUMBER || '', - remoteCallerName: '', - remoteCallerNumber: '', audio: true, video: true, }); diff --git a/packages/react-client/src/useTelnyxRTC.ts b/packages/react-client/src/useTelnyxRTC.ts index 28728eb7..f0929933 100644 --- a/packages/react-client/src/useTelnyxRTC.ts +++ b/packages/react-client/src/useTelnyxRTC.ts @@ -33,7 +33,7 @@ export type CredentialOptions = TokenCredential | UsernameCredential; */ function useTelnyxRTC( credentialParam: CredentialOptions, - clientOptions?: IClientOptions + clientOptions?: Partial ): TelnyxRTC | undefined { const telnyxClientRef = useRef(); @@ -44,6 +44,7 @@ function useTelnyxRTC( } telnyxClientRef.current = new TelnyxRTC({ + login_token: '', ...credentialParam, ...clientOptions, }); From b979f871a1492d37da038bc5f9e64a7a1510afe6 Mon Sep 17 00:00:00 2001 From: Sua Yoo Date: Fri, 15 Jan 2021 10:39:42 -0800 Subject: [PATCH 2/3] remove unsupported fields --- packages/react-client/README.md | 2 +- packages/react-client/example/package.json | 1 - packages/react-client/example/src/Phone.tsx | 2 - packages/react-client/package-lock.json | 130 +++----------------- packages/react-client/package.json | 3 +- 5 files changed, 20 insertions(+), 118 deletions(-) diff --git a/packages/react-client/README.md b/packages/react-client/README.md index b657b667..e3483a6e 100644 --- a/packages/react-client/README.md +++ b/packages/react-client/README.md @@ -7,7 +7,7 @@ ## Install ```bash -npm install --save @telnyx/react-client @telnyx/webrtc +npm install --save @telnyx/react-client ``` ## Usage example diff --git a/packages/react-client/example/package.json b/packages/react-client/example/package.json index 6976f65f..d033b553 100644 --- a/packages/react-client/example/package.json +++ b/packages/react-client/example/package.json @@ -12,7 +12,6 @@ }, "dependencies": { "@telnyx/react-client": "file:..", - "@telnyx/webrtc": "^2.2.4", "@testing-library/jest-dom": "file:../node_modules/@testing-library/jest-dom", "@testing-library/react": "file:../node_modules/@testing-library/react", "@testing-library/user-event": "file:../node_modules/@testing-library/user-event", diff --git a/packages/react-client/example/src/Phone.tsx b/packages/react-client/example/src/Phone.tsx index 66ad7e26..e1bfb1b3 100644 --- a/packages/react-client/example/src/Phone.tsx +++ b/packages/react-client/example/src/Phone.tsx @@ -13,8 +13,6 @@ function Phone() { destinationNumber: destination, callerName: process.env.REACT_APP_TELNYX_PHONE_NUMBER || '', callerNumber: process.env.REACT_APP_TELNYX_PHONE_NUMBER || '', - remoteCallerName: '', - remoteCallerNumber: '', audio: true, video: false, }); diff --git a/packages/react-client/package-lock.json b/packages/react-client/package-lock.json index 22b7ff93..784b4530 100644 --- a/packages/react-client/package-lock.json +++ b/packages/react-client/package-lock.json @@ -1758,88 +1758,6 @@ "@types/node": ">= 8" } }, - "@release-it/bumper": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/@release-it/bumper/-/bumper-2.0.0.tgz", - "integrity": "sha512-r8JeyuQfonY9g9CJjBcG1PrGZmpHIccbDb3TFyfTPknxFHVanE2gMGYijncE259zZ/oCo+u9fRpx0WkiRJxhtw==", - "dev": true, - "requires": { - "@iarna/toml": "^2.2.5", - "detect-indent": "^6.0.0", - "fast-glob": "^3.2.4", - "ini": "^1.3.5", - "js-yaml": "^3.14.0", - "lodash.castarray": "^4.4.0", - "lodash.get": "^4.4.2", - "lodash.set": "^4.3.2", - "mock-fs": "^4.13.0" - }, - "dependencies": { - "@nodelib/fs.stat": { - "version": "2.0.3", - "resolved": "https://registry.npmjs.org/@nodelib/fs.stat/-/fs.stat-2.0.3.tgz", - "integrity": "sha512-bQBFruR2TAwoevBEd/NWMoAAtNGzTRgdrqnYCc7dhzfoNvqPzLyqlEQnzZ3kVnNrSp25iyxE00/3h2fqGAGArA==", - "dev": true - }, - "braces": { - "version": "3.0.2", - "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.2.tgz", - "integrity": "sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==", - "dev": true, - "requires": { - "fill-range": "^7.0.1" - } - }, - "fast-glob": { - "version": "3.2.4", - "resolved": "https://registry.npmjs.org/fast-glob/-/fast-glob-3.2.4.tgz", - "integrity": "sha512-kr/Oo6PX51265qeuCYsyGypiO5uJFgBS0jksyG7FUeCyQzNwYnzrNIMR1NXfkZXsMYXYLRAHgISHBz8gQcxKHQ==", - "dev": true, - "requires": { - "@nodelib/fs.stat": "^2.0.2", - "@nodelib/fs.walk": "^1.2.3", - "glob-parent": "^5.1.0", - "merge2": "^1.3.0", - "micromatch": "^4.0.2", - "picomatch": "^2.2.1" - } - }, - "fill-range": { - "version": "7.0.1", - "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.0.1.tgz", - "integrity": "sha512-qOo9F+dMUmC2Lcb4BbVvnKJxTPjCm+RRpe4gDuGrzkL7mEVl/djYSu2OdQ2Pa302N4oqkSg9ir6jaLWJ2USVpQ==", - "dev": true, - "requires": { - "to-regex-range": "^5.0.1" - } - }, - "is-number": { - "version": "7.0.0", - "resolved": "https://registry.npmjs.org/is-number/-/is-number-7.0.0.tgz", - "integrity": "sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng==", - "dev": true - }, - "micromatch": { - "version": "4.0.2", - "resolved": "https://registry.npmjs.org/micromatch/-/micromatch-4.0.2.tgz", - "integrity": "sha512-y7FpHSbMUMoyPbYUSzO6PaZ6FyRnQOpHuKwbo1G+Knck95XVU4QAiKdGEnj5wwoS7PlOgthX/09u5iFJ+aYf5Q==", - "dev": true, - "requires": { - "braces": "^3.0.1", - "picomatch": "^2.0.5" - } - }, - "to-regex-range": { - "version": "5.0.1", - "resolved": "https://registry.npmjs.org/to-regex-range/-/to-regex-range-5.0.1.tgz", - "integrity": "sha512-65P7iz6X5yEr1cwcgvQxbbIw7Uk3gOy5dIdtZ4rDveLqhrdJP+Li/Hx6tyK0NEb+2GCyneCMJiGqrADCSNk8sQ==", - "dev": true, - "requires": { - "is-number": "^7.0.0" - } - } - } - }, "@rollup/plugin-alias": { "version": "3.1.1", "resolved": "https://registry.npmjs.org/@rollup/plugin-alias/-/plugin-alias-3.1.1.tgz", @@ -2212,6 +2130,24 @@ "defer-to-connect": "^2.0.0" } }, + "@telnyx/webrtc": { + "version": "2.3.2", + "resolved": "https://registry.npmjs.org/@telnyx/webrtc/-/webrtc-2.3.2.tgz", + "integrity": "sha512-C/kHy7CNvJjg1S1TP7tsiVLhiH0Wf/BfMSqi4anDBTXwe52jKChtsVf0AiK5sh867klrvdPT+1xQXyRQxnWxfA==", + "dev": true, + "requires": { + "loglevel": "^1.6.8", + "uuid": "^7.0.3" + }, + "dependencies": { + "uuid": { + "version": "7.0.3", + "resolved": "https://registry.npmjs.org/uuid/-/uuid-7.0.3.tgz", + "integrity": "sha512-DPSke0pXhTZgoF/d+WSt2QaKMCFSfx7QegxEWT+JOuHF5aWrKEn0G+ztjuJg/gG8/ItK+rbPCD/yNv8yyih6Cg==", + "dev": true + } + } + }, "@testing-library/dom": { "version": "6.16.0", "resolved": "https://registry.npmjs.org/@testing-library/dom/-/dom-6.16.0.tgz", @@ -6295,12 +6231,6 @@ "integrity": "sha1-l4hXRCxEdJ5CBmE+N5RiBYJqvYA=", "dev": true }, - "detect-indent": { - "version": "6.0.0", - "resolved": "https://registry.npmjs.org/detect-indent/-/detect-indent-6.0.0.tgz", - "integrity": "sha512-oSyFlqaTHCItVRGK5RmrmjB+CmaMOW7IaNA/kdxqhoa6d17j/5ce9O9eWXmV/KEdRwqpQA+Vqe8a8Bsybu4YnA==", - "dev": true - }, "detect-newline": { "version": "2.1.0", "resolved": "https://registry.npmjs.org/detect-newline/-/detect-newline-2.1.0.tgz", @@ -10748,18 +10678,6 @@ "integrity": "sha1-soqmKIorn8ZRA1x3EfZathkDMaY=", "dev": true }, - "lodash.castarray": { - "version": "4.4.0", - "resolved": "https://registry.npmjs.org/lodash.castarray/-/lodash.castarray-4.4.0.tgz", - "integrity": "sha1-wCUTUV4wna3dTCTGDP3c9ZdtkRU=", - "dev": true - }, - "lodash.get": { - "version": "4.4.2", - "resolved": "https://registry.npmjs.org/lodash.get/-/lodash.get-4.4.2.tgz", - "integrity": "sha1-LRd/ZS+jHpObRDjVNBSZ36OCXpk=", - "dev": true - }, "lodash.memoize": { "version": "4.1.2", "resolved": "https://registry.npmjs.org/lodash.memoize/-/lodash.memoize-4.1.2.tgz", @@ -10772,12 +10690,6 @@ "integrity": "sha512-0KpjqXRVvrYyCsX1swR/XTK0va6VQkQM6MNo7PqW77ByjAhoARA8EfrP1N4+KlKj8YS0ZUCtRT/YUuhyYDujIQ==", "dev": true }, - "lodash.set": { - "version": "4.3.2", - "resolved": "https://registry.npmjs.org/lodash.set/-/lodash.set-4.3.2.tgz", - "integrity": "sha1-2HV7HagH3eJIFrDWqEvqGnYjCyM=", - "dev": true - }, "lodash.sortby": { "version": "4.7.0", "resolved": "https://registry.npmjs.org/lodash.sortby/-/lodash.sortby-4.7.0.tgz", @@ -11464,12 +11376,6 @@ "minimist": "^1.2.5" } }, - "mock-fs": { - "version": "4.13.0", - "resolved": "https://registry.npmjs.org/mock-fs/-/mock-fs-4.13.0.tgz", - "integrity": "sha512-DD0vOdofJdoaRNtnWcrXe6RQbpHkPPmtqGq14uRX0F8ZKJ5nv89CVTYl/BZdppDxBDaV0hl75htg3abpEWlPZA==", - "dev": true - }, "module-details-from-path": { "version": "1.0.3", "resolved": "https://registry.npmjs.org/module-details-from-path/-/module-details-from-path-1.0.3.tgz", diff --git a/packages/react-client/package.json b/packages/react-client/package.json index f6607ff1..47f5de08 100644 --- a/packages/react-client/package.json +++ b/packages/react-client/package.json @@ -36,11 +36,10 @@ "bugs:": "https://github.com/team-telnyx/webrtc/issues", "license": "MIT", "peerDependencies": { - "@telnyx/webrtc": "^2.2.4", "react": "^16.0.0" }, "devDependencies": { - "@release-it/bumper": "^2.0.0", + "@telnyx/webrtc": "^2.3.2", "@testing-library/jest-dom": "^4.2.4", "@testing-library/react": "^9.5.0", "@testing-library/user-event": "^7.2.1", From c38f3ca34cc072362aa6dd941e13f4ffe0c9253b Mon Sep 17 00:00:00 2001 From: Sua Yoo Date: Fri, 15 Jan 2021 10:45:22 -0800 Subject: [PATCH 3/3] move out of dev dependenciees --- packages/react-client/package-lock.json | 7 ++----- packages/react-client/package.json | 4 +++- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/react-client/package-lock.json b/packages/react-client/package-lock.json index 784b4530..001da596 100644 --- a/packages/react-client/package-lock.json +++ b/packages/react-client/package-lock.json @@ -2134,7 +2134,6 @@ "version": "2.3.2", "resolved": "https://registry.npmjs.org/@telnyx/webrtc/-/webrtc-2.3.2.tgz", "integrity": "sha512-C/kHy7CNvJjg1S1TP7tsiVLhiH0Wf/BfMSqi4anDBTXwe52jKChtsVf0AiK5sh867klrvdPT+1xQXyRQxnWxfA==", - "dev": true, "requires": { "loglevel": "^1.6.8", "uuid": "^7.0.3" @@ -2143,8 +2142,7 @@ "uuid": { "version": "7.0.3", "resolved": "https://registry.npmjs.org/uuid/-/uuid-7.0.3.tgz", - "integrity": "sha512-DPSke0pXhTZgoF/d+WSt2QaKMCFSfx7QegxEWT+JOuHF5aWrKEn0G+ztjuJg/gG8/ItK+rbPCD/yNv8yyih6Cg==", - "dev": true + "integrity": "sha512-DPSke0pXhTZgoF/d+WSt2QaKMCFSfx7QegxEWT+JOuHF5aWrKEn0G+ztjuJg/gG8/ItK+rbPCD/yNv8yyih6Cg==" } } }, @@ -10784,8 +10782,7 @@ "loglevel": { "version": "1.7.0", "resolved": "https://registry.npmjs.org/loglevel/-/loglevel-1.7.0.tgz", - "integrity": "sha512-i2sY04nal5jDcagM3FMfG++T69GEEM8CYuOfeOIvmXzOIcwE9a/CJPR0MFM97pYMj/u10lzz7/zd7+qwhrBTqQ==", - "dev": true + "integrity": "sha512-i2sY04nal5jDcagM3FMfG++T69GEEM8CYuOfeOIvmXzOIcwE9a/CJPR0MFM97pYMj/u10lzz7/zd7+qwhrBTqQ==" }, "loose-envify": { "version": "1.4.0", diff --git a/packages/react-client/package.json b/packages/react-client/package.json index 47f5de08..fad7c8d0 100644 --- a/packages/react-client/package.json +++ b/packages/react-client/package.json @@ -38,8 +38,10 @@ "peerDependencies": { "react": "^16.0.0" }, + "dependencies": { + "@telnyx/webrtc": "^2.3.2" + }, "devDependencies": { - "@telnyx/webrtc": "^2.3.2", "@testing-library/jest-dom": "^4.2.4", "@testing-library/react": "^9.5.0", "@testing-library/user-event": "^7.2.1",