Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryReader fails to build on Windows #122

Closed
chadlwilson opened this issue Oct 2, 2024 · 4 comments
Closed

BinaryReader fails to build on Windows #122

chadlwilson opened this issue Oct 2, 2024 · 4 comments

Comments

@chadlwilson
Copy link

Hiya - 2.7.16 now falls to be able to compile on Windows due to 10517e1 with

 Error: C:\Users\runneradmin\go\pkg\mod\github.com\tdewolff\parse\[email protected]\binary.go:376:23: undefined: syscall.Mmap
Error: C:\Users\runneradmin\go\pkg\mod\github.com\tdewolff\parse\[email protected]\binary.go:376:63: undefined: syscall.PROT_READ
Error: C:\Users\runneradmin\go\pkg\mod\github.com\tdewolff\parse\[email protected]\binary.go:376:82: undefined: syscall.MAP_SHARED
Error: C:\Users\runneradmin\go\pkg\mod\github.com\tdewolff\parse\[email protected]\binary.go:396:17: undefined: syscall.Munmap

Is it expected to change Windows support/requirements in this patch release?

@Shnitzelil
Copy link

We have the same problem.
For now we fallback to 2.7.15.

@tdewolff
Copy link
Owner

Thanks for the heads-up, this is now fixed in v2.7.17

@chadlwilson
Copy link
Author

Thanks @tdewolff !

@Shnitzelil
Copy link

@tdewolff thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants