Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Key verification by QRCode #698

Closed
phloux opened this issue Dec 2, 2022 · 2 comments · Fixed by #728
Closed

Enable Key verification by QRCode #698

phloux opened this issue Dec 2, 2022 · 2 comments · Fixed by #728
Assignees

Comments

@phloux
Copy link

phloux commented Dec 2, 2022

Enable Key verification by QRCode like in Element.

@phloux phloux added the iOS label Dec 2, 2022
@giomfo
Copy link
Contributor

giomfo commented Jan 13, 2023

The QRCode is supported only in the Element self verification process.

This process is disabled for the moment in Tchap-iOS: https://github.com/tchapgouv/tchap-ios/blob/develop/Riot/Modules/KeyVerification/Common/KeyVerificationCoordinator.swift#L132

I think we commented the self verification process to keep using the customised verification (the legacy one)

We did some tests by enabling the self verification, this process prompts the QR code scanning as a first option.
The pb is the QR code is generated only if the cross-signing is enabled.
We observed in some cases this screen without Code, the user has to click on "Impossible de scanner" to start the emoji verification
image

@giomfo
Copy link
Contributor

giomfo commented Jan 13, 2023

A case where the code is visible only on one device has been reproduced with Element-iOS
1- Consider an iOS session where the cross-signing is enabled
2- Trigger from this session the verification of a new session
3- Accept the incoming verification request

a QR code is displayed on the new session screen, but no QR code is displayed on the first session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants