Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Automated Tests #306

Closed
jugglinmike opened this issue Jun 9, 2015 · 3 comments
Closed

Proposal: Automated Tests #306

jugglinmike opened this issue Jun 9, 2015 · 3 comments

Comments

@jugglinmike
Copy link
Contributor

I'd like to write some tests for test file content. As a start, these would
assert:

  • Valid YAML frontmatter syntax
  • Basic frontmatter tag requirements
    • Presence of description tag
    • Valid configurations
      • Mutual exclusivity of strictOnly and noStrict
      • At least one of es5id and es6id
  • Presence of copyright block

These assertions are admittedly a little weak, but even superficial checks like
these would have prevented past errors (e.g. gh-177, gh-225, gh-144). Because
test262 does not currently offer any automated tests, this work would involve
introducing the tooling and practices. That would reduce the friction in
implementing more substantial/helpful tests in the future (see for instance,
gh-276 and gh-297).

This will require some discussion about dependencies, but I wanted to see if
the basic proposal is desired before getting into technical details.

@jugglinmike
Copy link
Contributor Author

This could also enforce a restriction on description length that is currently requested in the project's contribution guidelines.

@leobalter
Copy link
Member

#546 will have us one step closer to solve this.

The items you have listed here sound reasonable to me.

@rwaldron
Copy link
Contributor

rwaldron commented Feb 7, 2020

This was addressed by implementing a linter that runs in our CI

@rwaldron rwaldron closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants