Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDN for Intl.PluralRules missing Digits options #378

Closed
longlho opened this issue Sep 22, 2019 · 6 comments
Closed

MDN for Intl.PluralRules missing Digits options #378

longlho opened this issue Sep 22, 2019 · 6 comments
Labels
c: numbers Component: numbers, currency, units question

Comments

@longlho
Copy link
Collaborator

longlho commented Sep 22, 2019

Following on #365 (comment)

I made the edit on MDN (and it seems to get saved) but I'm not sure if that's the right way to do it? Is there a contribution doc?

@sffc
Copy link
Contributor

sffc commented Sep 23, 2019

@romulocintra @jahzielv

@sffc sffc added c: numbers Component: numbers, currency, units question labels Sep 23, 2019
@romulocintra
Copy link
Member

romulocintra commented Sep 23, 2019

Hi @longlho thanks for your contribution on MDN, we recently started "trying" to have a certain order and tracking regarding the documentation.

At the moment we are focused on following "new" proposals that don't have or have a short documentation in MDN (Example of issue Intl.RelativeTimeFormat).

Assuming that documenting new and existent API's shouldn't be a one time github issue probably we should agree in opening small issues to track small updates instead of having one that holds small tasks.

Organizing the way we document, track, and organize the people that can give a hand on that, should be probably a good topic in one of the next Meetings . Do you agree @sffc ?

@sffc
Copy link
Contributor

sffc commented Sep 23, 2019

I think for MDN, first we need to make sure new PRs and proposals are fully documented in English. In my opinion, that step should block PRs and proposals from advancing. I added a column for it in the wiki:

https://github.com/tc39/ecma402/wiki/Proposal-and-PR-Progress-Tracking

Then, once the initial documentation is written, we can translate to more written languages, fix problems with the existing documentation (like this issue is for), etc. However, I don't think this is the right forum to track those issues. Is there an MDN GitHub where such issues can be filed?

@longlho
Copy link
Collaborator Author

longlho commented Sep 26, 2019

Thanks for the info but I'm not sure if that answered my question regarding MDN contributions. Specifically what I'm looking for are:

  1. Is clicking Edit on the MDN page the correct way to make changes?
  2. Is there some PR flow for MDN changes, or is this maintained similarly to wikipedia where everyone can make changes?

@jahzielv
Copy link

Hi @longlho, great questions, and thanks for your contribution!

  1. Yep, that's correct! Just clicking edit will let you make the changes to the pages.
  2. Exactly right – MDN is a wiki-style site, where anyone can make changes. There are folks at Mozilla as well as volunteer moderators that review changes, but there's not a PR flow for changes to land.

@longlho
Copy link
Collaborator Author

longlho commented Sep 26, 2019

Gotcha thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: numbers Component: numbers, currency, units question
Projects
None yet
Development

No branches or pull requests

4 participants