Do not quote Multipart fields in forms #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aiohttp.FormData` default is to encode all parameter data on form fields, and this causes e.g. spaces to be converted to `%20`, which are then [exposed in the Paperless-NGX UI](paperless-ngx/paperless-ngx#6830). I interpret the [`aiohttp` issue](aio-libs/aiohttp#6826) to mean that the filename should *not* be percent-encoded, and the [proposed solution](aio-libs/aiohttp#6826 (comment)) is to set `quote_fields=False` in the constructor of `aiohttp.FormData`. Which is what this PR does. Signed-off-by: martin f. krafft <[email protected]>
|
I cannot add labels so I cannot massage this into passing the workflow. Sorry. |
tb1337
added
the
bugfix
|
Thank you, I approved the PR :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aiohttp.FormDatadefault is to encode all parameter data on form fields, and this causes e.g. spaces to be converted to%20, which are then exposed in the Paperless-NGX UI.I interpret the
aiohttpissue to mean that the filename should not be percent-encoded, and the proposed solution is to setquote_fields=Falsein the constructor ofaiohttp.FormData.Which is what this PR does.