Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): correct module name resolution for clipboard and globalShortcut plugins #9931

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix(cli): correct module name resolution for clipboard and globalShortcut plugins #9931

merged 2 commits into from
Jun 3, 2024

Conversation

kareemmahlees
Copy link
Contributor

closes #9905

@kareemmahlees kareemmahlees requested a review from a team as a code owner May 31, 2024 09:01
@FabianLars
Copy link
Member

FabianLars commented Jun 3, 2024

Thanks for contributing! I think it'd make more sense to use heck (already a dependency in tauri) to convert the module name automatically so that we don't have to change it every time there's a new plugin.

Nevermind, just noticed that this is only about the migrate command, sorry.

@amrbashir
Copy link
Member

Thanks for contribution

@amrbashir amrbashir merged commit 019a74e into tauri-apps:dev Jun 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] tauri migrate mis resolves globalShortcut & clipboard npm modules
3 participants