feat(bundler): support custom sign command on Windows #9902
Conversation
done |
There was a problem hiding this comment.
Maybe it needs to be modified here.
@amrbashir Could you please take a look at it?
| @@ -68,6 +67,7 @@ pub fn bundle_project(settings: &Settings, updater: bool) -> crate::Result<Vec<P | |||
| let nsis_toolset_path = tauri_tools_path.join("NSIS"); | |||
|
|
|||
| if !nsis_toolset_path.exists() { | |||
| create_dir_all(&nsis_toolset_path)?; | |||
There was a problem hiding this comment.
Creating an NSIS folder in advance will cause subsequent renaming failures after extract
rename(_tauri_tools_path.join("nsis-3.08"), nsis_toolset_path)?;
|
@amrbashir any thoughts on when v1.7 would be released that contains this fix? |
|
I don't want to make promises but hopefully this week |
|
@amrbashir I see 1.7 came out, but I don't see anything about this feature in the release notes, is it indeed in there? |
|
Maybe a silly question, but I have tauri updated to 1.7.1 (and tauri-build updated to 1.5.3) so everything appears to be updated to latest, but I cannot build with "signCommand".
Anyone know why? |
|
make sure to also update the CLI |
feat: Migrate v2 functionality to v1.x: support custom sign command on Windows (Discussed in #9900)