-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add macos hardened runtime signing config option #9318
feat(cli): add macos hardened runtime signing config option #9318
Conversation
Just a gentle reminder: I'm currently unable to test my app build locally due to the damaged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just some smaller things and then it's good to go :)
Thanks for the review : - ) |
…ps#9318) * feat(cli): add macos signing config option * rename option to hardened_runtime * chore(cli): use default true in hardened runtime config --------- Co-authored-by: Lucas Nogueira <[email protected]>
* feat(cli): add macos signing config option * rename option to hardened_runtime * chore(cli): use default true in hardened runtime config --------- Co-authored-by: Lucas Nogueira <[email protected]>
…10199) * feat(cli): add macos signing config option * rename option to hardened_runtime * chore(cli): use default true in hardened runtime config --------- Co-authored-by: Lucas Nogueira <[email protected]>
In
macOS
, when buildingdmg
withad-hoc
signature, and the app depends on Frameworks (dynamic shared libraries,dylib
files), they won't load and the app will crash with error message box.I found that if we disable signing flag in
macOS
bundler passed fromtauri-cli
, it won't crash.the flag which passed is
--option runtime
in tooling/bundler/src/bundle/macos/sign.rs#L210crash log
man codesign
This PR introduce a way to control the flag through
tauri.conf.json
:I believe that macOS bundling process needs to be much more flexible.
Currently I have no other option to control the final signing of the app, and tauri enforce this
runtime
flag, as a result the final binary can't run and I can't publish it for macOS (arm).meanwhile for testing the app, it's possible to resign it: