Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for android studio which installed by jetbrains toolbox #88

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

cxgreat2014
Copy link
Contributor

@cxgreat2014 cxgreat2014 commented Feb 6, 2023

The android studio which installed by jetbrains toolbox will not have the "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Android Studio\\UninstallString" in the registry, but Jetbrain Toolbox will auto generate a studio.cmd for Android Studio, so we can use it to launch Android Studio for toolbox user.

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cxgreat2014
Copy link
Contributor Author

Seems like I'm the first one to do this...I'm confused about the package name in the change file, could you please provide an example?

@amrbashir
Copy link
Member

it looks something like this

---
"tauri-mobile": patch
---

Change summary here

@cxgreat2014
Copy link
Contributor Author

Like this?

Add_open_support_for_Andriod_Studio.md

---
"tauri-mobile": patch
---

Added open support for Android Studio installed by JetBrains Toolbox

@amrbashir
Copy link
Member

just needs a slight word change

---
"tauri-mobile": patch
---

Added support for opening Android Studio installed by JetBrains Toolbox

thanks

@cxgreat2014
Copy link
Contributor Author

Added, Thanks~

@amrbashir amrbashir merged commit 448fa99 into tauri-apps:dev Feb 7, 2023
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants