Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Window Progress Bar #418

Closed
tauri-bot opened this issue Jun 5, 2022 · 7 comments · Fixed by #742
Closed

[feat] Window Progress Bar #418

tauri-bot opened this issue Jun 5, 2022 · 7 comments · Fixed by #742

Comments

@tauri-bot
Copy link

This issue has been upstreamed from tauri-apps/tauri#4208

Describe the problem

It's a shame that Tauri doesn't have an API similar to Electron's Progress Bar, it's very useful for showing progress in minimized windows.

Describe the solution you'd like

An API similar to the Electron one, or even a Tao method that we could invoke in Rust code to set the progress quickly.

Alternatives considered

No response

Additional context

No response

@MegaSa1nt
Copy link

Is there any progress on this feature?
It would be awesome to have it in Tauri

@pewsheen
Copy link
Contributor

I'll take the macOS part after #742 merged

amrbashir added a commit that referenced this issue Jul 7, 2023
* add support for Windows Progress Bar

* set_taskbar_progress->set_window_taskbar_progress

* Implement enums for Taskbar State

* fix broken install on linux

* trying to make progressbar on linux

* implementing empty methods for taskbar progress

* fix deleted references

* set_taskbar_progress & set_taskbar_progress_state for linux

* Fix an issue affecting when it can't plot progressbar

* cargo fmt

* introduce the unity (gnome) taskbar

* test smth

* typo 💀

* Update implementTaskbarProgress.md

* Update src/window.rs

Refactor

Co-authored-by: Amr Bashir <[email protected]>

* Update src/window.rs

Refactor

Co-authored-by: Amr Bashir <[email protected]>

* Remove Duplicate lazy_static

* Update window.rs

Explained why it might not work on some distros of linux

* Remove x11rb, move to platform implementations etc

* Format

* remove xapps & tried to impl zbus

* Typo I guess

* Revert

* Format

* Change zbus: 3.13.1 to 3.13

Co-authored-by: Amr Bashir <[email protected]>

* Try the new zbus impl

* Finally the current review

* cargo fmt

* Implement a progress checker

* Apply suggestions from code review

Co-authored-by: Amr Bashir <[email protected]>

* Implement The Requested Changes

* Update src/platform_impl/linux/event_loop.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/platform_impl/linux/taskbar.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/window.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/window.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/platform_impl/linux/taskbar.rs

Co-authored-by: Amr Bashir <[email protected]>

* impl review changes

* [Untested] Change zbus to 3

* Typo

* Update src/platform_impl/linux/util.rs

Co-authored-by: Jason Tsai <[email protected]>

* Update src/platform_impl/linux/taskbar.rs

Co-authored-by: Jason Tsai <[email protected]>

* Update util.rs

* Update src/event_loop.rs

Co-authored-by: Jason Tsai <[email protected]>

* Update src/window.rs

Co-authored-by: Jason Tsai <[email protected]>

* Update src/event_loop.rs

* chore: format

* Update src/event_loop.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/platform_impl/linux/util.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/platform_impl/linux/event_loop.rs

Co-authored-by: Amr Bashir <[email protected]>

* Update src/platform_impl/linux/window.rs

Co-authored-by: Amr Bashir <[email protected]>

* Move Logic below GlobalHotKey

* Chore: cargo fmt

* Update .changes/implementTaskbarProgress.md

* Update util.rs

* Typo, confused with rust & js

* Update util.rs

* WindowId::dummy().taskbar_progress not working

typo

* remove the normal impl

---------

Co-authored-by: Amr Bashir <[email protected]>
Co-authored-by: Jason Tsai <[email protected]>
@amrbashir
Copy link
Member

@pewsheen feel free to add macOS implementation

@matthiasg
Copy link

Only mac works right now or is this really closed ?

@amrbashir
Copy link
Member

Windows and Linux (Ubuntu) should be working too.

@jecsham
Copy link

jecsham commented Feb 29, 2024

Is this implemented on v1? Or do we have to wait for v2?

@FabianLars
Copy link
Member

It's v2 only. I think it can be backported to 0.16 (the tao version tauri v1 uses) fine, but the team has no resources to do that ourselves. So if no community members opens a PR for this it will likely stay v2 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants