Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for tauri-hotkey migration #33

Closed
4 tasks
lemarier opened this issue May 8, 2021 · 1 comment · Fixed by #82
Closed
4 tasks

Tracking issue for tauri-hotkey migration #33

lemarier opened this issue May 8, 2021 · 1 comment · Fixed by #82

Comments

@lemarier
Copy link
Member

lemarier commented May 8, 2021

We should use https://github.com/tauri-apps/tauri-hotkey-rs

  • Expose the manager somehow so tauri can re-use it
  • Add new event type Hotkey or something similar
  • Use tauri-hotkey for Windows menu accelerators
  • Make sure accelerators sent to custom menu use Hotkey struct or string compatible with tauri-hotkey
@lucasfernog
Copy link
Member

I think a good approach would be moving the key bindings from tauri-hotkey to a tauri-keys repo, and add a new formatting function, to_gtk_string or something like that. Then we can use it on both libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants