From 69e4c2e56f1b721775546050b9ebf57376eba9f8 Mon Sep 17 00:00:00 2001 From: Amr Bashir Date: Sat, 25 May 2024 16:26:27 +0300 Subject: [PATCH] fix(updater): pass `/NS` and `/UPDATE` to nsis installer to disable creating shortcuts on updates (#1162) * fix(updater): pass `/NS` to nsis installer to disable creating shortcuts on updates ref: tauri-apps/tauri#9395 * add `/UPDATE` * move args to function * update updater test config * revert /R --------- Co-authored-by: Lucas Nogueira --- .changes/updater-nsis-shortcuts.md | 5 +++++ plugins/updater/src/updater.rs | 2 ++ plugins/updater/tests/app-updater/tauri.conf.json | 4 ++-- 3 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 .changes/updater-nsis-shortcuts.md diff --git a/.changes/updater-nsis-shortcuts.md b/.changes/updater-nsis-shortcuts.md new file mode 100644 index 0000000000..0226b419a7 --- /dev/null +++ b/.changes/updater-nsis-shortcuts.md @@ -0,0 +1,5 @@ +--- +"updater": "patch" +--- + +Fix NSIS updater creating new shortcuts on update. \ No newline at end of file diff --git a/plugins/updater/src/updater.rs b/plugins/updater/src/updater.rs index e800a45ca7..ebc0e6942a 100644 --- a/plugins/updater/src/updater.rs +++ b/plugins/updater/src/updater.rs @@ -556,6 +556,8 @@ impl Update { match updater_type { WindowsUpdaterType::Nsis => { installer_args.extend(install_mode.nsis_args().iter().map(OsStr::new)); + installer_args.push(OsStr::new("/NS")); + installer_args.push(OsStr::new("/UPDATE")); } WindowsUpdaterType::Msi => { installer_args.extend(install_mode.msiexec_args().iter().map(OsStr::new)); diff --git a/plugins/updater/tests/app-updater/tauri.conf.json b/plugins/updater/tests/app-updater/tauri.conf.json index 4c891ab9a2..44c955a62a 100644 --- a/plugins/updater/tests/app-updater/tauri.conf.json +++ b/plugins/updater/tests/app-updater/tauri.conf.json @@ -21,8 +21,8 @@ "icons/icon.ico" ], "windows": { - "wix": { - "skipWebviewInstall": true + "webviewInstallMode": { + "type": "skip" } } }