feat: make prc errors ban-able for sync #5884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made RPC errors ban-able during header-sync and horizon-sync ban-able with a short ban duration.
ghpbot-tari-project
added
P-acks_required
SWvheerden
approved these changes
Oct 31, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made RPC errors ban-able during header-sync and horizon-sync ban-able with a short ban duration.
Closes #5874
Motivation and Context
During sync, we establish a client-server connection and then execute RPC methods from the client to the server, which we know should succeed, so that any RPC errors afterwards are a banable offence. Something else to consider is that sync only acts if better peer metadata is received from a peer, translating to malicious behaviour should a peer not want to play the protocol afterwards.
How Has This Been Tested?
Integration-level unit tests in
base_layer\core\tests\tests:block_sync.rsheader_sync.rshorizon_sync.rs(still in progress)What process can a PR reviewer use to test or verify this change?
Breaking Changes