fix(comms/rpc): increase max frame size limit for rpc requests #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we should ensure that a negotiated & finalized transaction can always be submitted to a base node.
For example, a unit test can verify max transaction constants (MAX_TRANSACTION_INPUTS, MAX_TRANSACTION_OUTPUTS) to calculate an approximate maximum transaction size (using normal transaction inputs and outputs) and compare it to RPC_MAX_FRAME_SIZE.
sdbondi
force-pushed
the
comms-rpc-increase-frame-size-limit
branch
from
61065d7 to
50747fb
Compare
hansieodendaal
approved these changes
Sep 23, 2022
stringhandler
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases max frame size for RPC from 2MiB to 3MiB
Motivation and Context
A wallet may need submit transactions greater than 2MiB in size
How Has This Been Tested?
Existing tests pass