Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): edge case fix for chunked iterator #4315

Merged
merged 2 commits into from
Jul 18, 2022
Merged

fix(core): edge case fix for chunked iterator #4315

merged 2 commits into from
Jul 18, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jul 15, 2022

Description

  • Handles edge case where overflow would occur but remainder is 0 in reverse implementation.
  • Prevent iterator_symmetry test from running forever in failure case.
  • Add failure case to tests

Motivation and Context

iterator_symmetry test fails sporadically, and a bug was found in the reverse iterator.

How Has This Been Tested?

Added new test for failure case

@aviator-app aviator-app bot merged commit 8854ca1 into tari-project:development Jul 18, 2022
@sdbondi sdbondi deleted the core-chunked-iterator-fix branch July 18, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdbondi @stringhandler