Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base_layer): validate duplicated acceptances #4233

Merged
merged 2 commits into from
Jun 28, 2022
Merged

feat(base_layer): validate duplicated acceptances #4233

merged 2 commits into from
Jun 28, 2022

Conversation

mrnaveira
Copy link
Contributor

Description

  • Added new validation for contract acceptances: validator nodes can only accept a contract once
  • Added a unit test to check that the constitution must exist beforehand
  • Refactored some redundant helper code for validations

Motivation and Context

The base layer should check that no duplicated acceptances (same contract and validator node) are published.

How Has This Been Tested?

  • New unit test to check the new validation
  • The existing unit and integration tests pass

@aviator-app aviator-app bot merged commit 3d8a3b2 into tari-project:development Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrnaveira @stringhandler