Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base_layer): basic contract constitution validation #4232

Merged
merged 2 commits into from
Jun 27, 2022
Merged

feat(base_layer): basic contract constitution validation #4232

merged 2 commits into from
Jun 27, 2022

Conversation

mrnaveira
Copy link
Contributor

Description

  • New DAN base layer validator for contract constitutions, checks that:
    • The definition for the contract must be published beforehand
    • There is no other constitution already published for that contract
  • Refactored some redundant helper code for validations

Motivation and Context

The base layer should check the basic requirements of a valid contract constitution: the definition must already be published and there are no duplicated constitutions.

How Has This Been Tested?

  • New unit tests to check the new validations
  • The existing unit and integration tests pass

@aviator-app aviator-app bot merged commit c2efd5e into tari-project:development Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrnaveira @stringhandler