feat(core): adds constitution UTXO features #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-add-constitution-structure
branch
from
50be94b to
55eb217
Compare
SWvheerden
previously approved these changes
May 23, 2022
| @@ -67,6 +67,11 @@ pub struct OutputFeatures { | |||
| #[serde(default)] | |||
| pub recovery_byte: u8, | |||
| pub metadata: Vec<u8>, | |||
| // TODO: Add these fields | |||
| // pub contract_id: Option<FixedHash>, | |||
| // pub constitution: Option<ContractConstitution>, | |||
There was a problem hiding this comment.
Do we want to add flags for these as well?
Or are we going with the presence of them is enough?
There was a problem hiding this comment.
OutputFlags already exist for the constitution. Whenever a contract_id is present we likely want one of those flags to be set
Comment on lines
+176
to
+177
| pub max_new_committee_members: u32, | ||
| /// The maximum number of committee members that can be evicted. | ||
| pub max_evicted_committee_members: u32, |
There was a problem hiding this comment.
Perhaps more options are better, but I don't see any reason why we would limit these two fields
There was a problem hiding this comment.
Yeah wasn't sure what settings we want to add to this. Should only have settings that are useful since each setting translates into more validation complexity and impact performance. Suggestions welcome. Could also leave this out for now.
sdbondi
force-pushed
the
core-add-constitution-structure
branch
from
55eb217 to
af4f8ae
Compare
sdbondi
force-pushed
the
core-add-constitution-structure
branch
from
af4f8ae to
a42fdda
Compare
stringhandler
approved these changes
May 25, 2022
aviator-app bot
pushed a commit
that referenced
this pull request
May 26, 2022
Description --- Based on #4122 #4129 #4121 - adds `SideChainFeatures` to `OutputFeatures` - updates code and tests - updates cucumber output feature consensus encoding - allows MaxSizeVec to be used directly in consensus encoded structs Motivation and Context --- Partial implementation of RFC 312 contract constitution How Has This Been Tested? --- - New consensus de/encoding tests - Manually on igor - cucumbers pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ContractConstitutionand related structsConsensusConstitutionConsensusEncoding,DerefandDerefMutforMaxSizeVeccheck_consensus_encoding_correctnessMotivation and Context
Add initial structs for contract constitution UTXO. Adding this to OutputFeatures is left for a subsequent PR.
How Has This Been Tested?
Unit tests for consensus encoding